Add AMD compatibility for OffloadPC#5220
Open
dsroberts wants to merge 1 commit into
Open
Conversation
connorjward
approved these changes
Jul 7, 2026
connorjward
left a comment
Contributor
There was a problem hiding this comment.
Awesome. Very happy to see (a) how tiny the diff needs to be and (b) the first real use of CommunityArch!
Since I can't rely on CI for this, are you happy for me to go ahead and merge this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add AMD GPU compatibility for
OffloadPCPETSc supports AMD GPUs through its CUPM abstraction layer, so extending
OffloadPCsupport to AMD GPUs is a matter of associating the HIP matrix/vector types with the PETScHIPdevice type. Also include an Ubuntu 24.04 HIP/ROCmCommunityArchinfiredrake-configure.