update files to allow r-theta coords centred off 0,0#708
Open
12shughes wants to merge 8 commits into
Open
Conversation
jshipton
requested changes
Feb 27, 2026
| elif rotation is CoriolisOptions.gammaplane: | ||
| x, y = SpatialCoordinate(self.domain.mesh) | ||
| r, _ = rtheta_from_xy(x, y) | ||
| r, _ = rtheta_from_xy(x, y, self.parameters.x0, self.parameters.y0) |
Contributor
There was a problem hiding this comment.
Would be good to make the default here centered on the pole - so you need to pass in Lx/2 and Ly/2 instead of setting x0 and y0 in the parameters class. You could try:
Lx=mesh.coordinates.dat.data[:, 0].max()
Ly=mesh.coordinates.dat.data[:, 1].max()
Collaborator
Author
There was a problem hiding this comment.
So would we take out the x0 and y0 argument entirely in the parameters? Or have them set to None by default but if they're specified then the chosen values are used here?
Contributor
There was a problem hiding this comment.
I think take them out - we don't want to suggest that something works when we haven't tried it (and in this case I'm not sure of why anyone would want to do this!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.