feat: added tests fo template APIs

Author: chetanr25

tests/conftest.py

@@ -15,7 +15,7 @@
 from app.main import app
 from app.api.deps import get_db
 from app.core.config import API_PREFIX  # single source of truth for all tests
-from app.models import Template, FormSubmission, Job, Input, Extraction, Incident, Form, Report  # noqa: F401 — registers tables
+from app.models import Template, FormSubmission, FormTemplate, Job, Input, Extraction, Incident, Form, Report  # noqa: F401 — registers tables
 
 # ---------------------------------------------------------------------------
 # In-memory database
@@ -85,18 +85,25 @@ def pdf_upload(pdf_bytes):
 # ---------------------------------------------------------------------------
 @pytest.fixture
 def mock_controller():
-    """Patch Controller so create_template / fill_form don't touch the FS or LLM."""
-    with patch("app.api.routes.templates.Controller") as tpl_cls, \
-         patch("app.api.routes.forms.Controller") as form_cls:
-        tpl_instance = MagicMock()
-        tpl_instance.create_template.return_value = "src/inputs/test_template.pdf"
-        tpl_cls.return_value = tpl_instance
-
+    """Patch the forms Controller so fill_form doesn't touch the FS or LLM."""
+    with patch("app.api.routes.forms.Controller") as form_cls:
         form_instance = MagicMock()
         form_instance.fill_form.return_value = "src/outputs/filled_output.pdf"
         form_cls.return_value = form_instance
 
-        yield {
-            "template_ctrl": tpl_instance,
-            "form_ctrl": form_instance,
-        }
+        yield {"form_ctrl": form_instance}
+
+
+@pytest.fixture
+def seed_template():
+    """Insert a legacy Template row directly (the /templates/create endpoint was
+    removed in the contract migration). Returns a factory -> template id."""
+    def _make(name: str = "T", pdf_path: str = "src/inputs/t.pdf", fields: dict | None = None) -> int:
+        with Session(_engine) as session:
+            tpl = Template(name=name, pdf_path=pdf_path, fields=fields if fields is not None else {"name": "string"})
+            session.add(tpl)
+            session.commit()
+            session.refresh(tpl)
+            return tpl.id
+
+    return _make

tests/test_api.py

@@ -84,104 +84,21 @@ def test_list_templates_ordering(self, db):
 class TestTemplateEndpoints:
 
     def test_list_templates_empty(self, client):
+        """Contract registry list is empty until a template is registered."""
         resp = client.get(f"{API_PREFIX}/templates")
         assert resp.status_code == 200
         assert resp.json() == []
 
-    def test_create_template(self, client, mock_controller):
-        payload = {
-            "name": "Fire Report",
-            "pdf_path": "src/inputs/fire_report.pdf",
-            "fields": {
-                "Name": "string",
-                "Date": "string",
-                "Location": "string",
-            },
-        }
-        resp = client.post(f"{API_PREFIX}/templates/create", json=payload)
-        assert resp.status_code == 200
-
-        data = resp.json()
-        assert data["id"] is not None
-        assert data["name"] == "Fire Report"
-        assert data["fields"]["Location"] == "string"
-        # Plain create just persists the row; commonforms only runs via
-        # the separate /make-fillable endpoint.
-        mock_controller["template_ctrl"].create_template.assert_not_called()
-
-    def test_create_then_list(self, client, mock_controller):
-        """Creating a template should make it appear in the list."""
-        client.post(f"{API_PREFIX}/templates/create", json={
-            "name": "T1",
-            "pdf_path": "a.pdf",
-            "fields": {"f": "string"},
-        })
-        resp = client.get(f"{API_PREFIX}/templates")
-        assert resp.status_code == 200
-        assert len(resp.json()) == 1
-        assert resp.json()[0]["name"] == "T1"
-
-    def test_upload_pdf(self, client, pdf_upload, tmp_path, monkeypatch):
-        """Upload a valid PDF file."""
-        # Point the upload directory inside tmp_path (which is inside the project
-        # for the path-safety check — we monkeypatch the check).
-        monkeypatch.setattr(
-            "app.api.routes.templates.PROJECT_ROOT",
-            tmp_path,
-        )
-        resp = client.post(
-            f"{API_PREFIX}/templates/upload",
-            files=[pdf_upload],
-            data={"directory": str(tmp_path)},
-        )
-        assert resp.status_code == 200
-        data = resp.json()
-        assert data["filename"] == "test_form.pdf"
-        assert data["pdf_path"].endswith(".pdf")
-
-    def test_upload_non_pdf_rejected(self, client):
-        import io
-        bad_file = ("file", ("notes.txt", io.BytesIO(b"hello"), "text/plain"))
-        resp = client.post(f"{API_PREFIX}/templates/upload", files=[bad_file])
-        assert resp.status_code == 400
-        assert "PDF" in resp.json()["detail"]
-
-    def test_preview_missing_file(self, client):
-        resp = client.get(f"{API_PREFIX}/templates/preview", params={"path": "src/inputs/nonexistent.pdf"})
-        assert resp.status_code == 404
-
-    def test_directory_traversal_blocked(self, client):
-        import io
-        pdf = ("file", ("evil.pdf", io.BytesIO(b"%PDF-1.4"), "application/pdf"))
-        resp = client.post(
-            f"{API_PREFIX}/templates/upload",
-            files=[pdf],
-            data={"directory": "/etc"},
-        )
-        assert resp.status_code == 400
-        assert "inside the project" in resp.json()["detail"]
-
 
 # ═══════════════════════════════════════════════════════════════════════════
-# Form fill endpoints
+# Form fill endpoints (legacy pipeline — templates seeded directly in the DB
+# since the /templates/create endpoint was removed in the contract migration)
 # ═══════════════════════════════════════════════════════════════════════════
 
 class TestFormEndpoints:
 
-    def _seed_template(self, client, mock_controller):
-        """Helper: create a template and return its ID."""
-        resp = client.post(f"{API_PREFIX}/templates/create", json={
-            "name": "Employee Form",
-            "pdf_path": "src/inputs/employee.pdf",
-            "fields": {
-                "Employee's name": "string",
-                "Employee's email": "string",
-            },
-        })
-        return resp.json()["id"]
-
-    def test_fill_form_success(self, client, mock_controller):
-        tpl_id = self._seed_template(client, mock_controller)
+    def test_fill_form_success(self, client, mock_controller, seed_template):
+        tpl_id = seed_template()
 
         resp = client.post(f"{API_PREFIX}/forms/fill", json={
             "template_id": tpl_id,
@@ -202,8 +119,8 @@ def test_fill_form_missing_template(self, client, mock_controller):
         })
         assert resp.status_code == 404
 
-    def test_fill_form_template_file_not_found(self, client, mock_controller):
-        tpl_id = self._seed_template(client, mock_controller)
+    def test_fill_form_template_file_not_found(self, client, mock_controller, seed_template):
+        tpl_id = seed_template()
         mock_controller["form_ctrl"].fill_form.side_effect = FileNotFoundError("PDF template not found")
 
         resp = client.post(f"{API_PREFIX}/forms/fill", json={
@@ -283,9 +200,9 @@ def boom(*a, **k):
         assert resp.status_code == 200
         assert resp.json()["models"] == ["qwen2.5:1.5b"]
 
-    def test_fill_form_passes_model_override(self, client, mock_controller):
+    def test_fill_form_passes_model_override(self, client, mock_controller, seed_template):
         """A `model` in the request reaches Controller.fill_form but isn't persisted."""
-        tpl_id = self._seed_template(client, mock_controller)
+        tpl_id = seed_template()
         resp = client.post(f"{API_PREFIX}/forms/fill", json={
             "template_id": tpl_id,
             "input_text": "John Doe",
@@ -316,45 +233,27 @@ def fake_post(*args, **kwargs):
 
 class TestE2EPipeline:
     """
-    Full pipeline: upload PDF → create template → fill form → verify DB state.
-    This is the critical path that the product depends on.
+    Legacy fill pipeline: seed template → fill form → verify DB state.
+    Template registration via API was removed in the contract migration, so the
+    template is seeded directly in the DB.
     """
 
-    def test_full_flow(self, client, mock_controller, pdf_upload, tmp_path, monkeypatch, db):
-        # -- Step 1: Upload a PDF --
-        monkeypatch.setattr("app.api.routes.templates.PROJECT_ROOT", tmp_path)
-        upload_resp = client.post(
-            f"{API_PREFIX}/templates/upload",
-            files=[pdf_upload],
-            data={"directory": str(tmp_path)},
-        )
-        assert upload_resp.status_code == 200
-        uploaded_path = upload_resp.json()["pdf_path"]
-        assert uploaded_path.endswith(".pdf")
-
-        # -- Step 2: Create a template from the uploaded PDF --
-        create_resp = client.post(f"{API_PREFIX}/templates/create", json={
-            "name": "Incident Report",
-            "pdf_path": uploaded_path,
-            "fields": {
+    def test_full_flow(self, client, mock_controller, seed_template, db):
+        # -- Step 1: Seed a template --
+        template_id = seed_template(
+            name="Incident Report",
+            pdf_path="src/inputs/incident.pdf",
+            fields={
                 "Officer name": "string",
                 "Badge number": "string",
                 "Incident date": "string",
                 "Location": "string",
                 "Description": "string",
             },
-        })
-        assert create_resp.status_code == 200
-        template_id = create_resp.json()["id"]
+        )
         assert template_id is not None
 
-        # -- Step 3: Verify template appears in list --
-        list_resp = client.get(f"{API_PREFIX}/templates")
-        assert list_resp.status_code == 200
-        templates = list_resp.json()
-        assert any(t["id"] == template_id for t in templates)
-
-        # -- Step 4: Fill the form --
+        # -- Step 2: Fill the form --
         fill_resp = client.post(f"{API_PREFIX}/forms/fill", json={
             "template_id": template_id,
             "input_text": (