Skip to content

Commit 26147cc

Browse files
authored
Remove unused isInverted prop from FlameGraphCanvas. (#6116)
Small cleanup.
2 parents d0e29c9 + 361a5a9 commit 26147cc

2 files changed

Lines changed: 1 addition & 9 deletions

File tree

src/components/flame-graph/Canvas.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ export type OwnProps = {
7070
readonly scrollToSelectionGeneration: number;
7171
readonly categories: CategoryList;
7272
readonly interval: Milliseconds;
73-
readonly isInverted: boolean;
7473
readonly callTreeSummaryStrategy: CallTreeSummaryStrategy;
7574
readonly ctssSamples: SamplesLikeTable;
7675
readonly ctssSampleCategoriesAndSubcategories: SampleCategoriesAndSubcategories;

src/components/flame-graph/FlameGraph.tsx

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,7 @@ import {
1616
getProfileUsesMultipleStackTypes,
1717
} from 'firefox-profiler/selectors/profile';
1818
import { selectedThreadSelectors } from 'firefox-profiler/selectors/per-thread';
19-
import {
20-
getSelectedThreadsKey,
21-
getInvertCallstack,
22-
} from '../../selectors/url-state';
19+
import { getSelectedThreadsKey } from '../../selectors/url-state';
2320
import { ContextMenuTrigger } from 'firefox-profiler/components/shared/ContextMenuTrigger';
2421
import {
2522
changeSelectedCallNode,
@@ -83,7 +80,6 @@ type StateProps = {
8380
readonly scrollToSelectionGeneration: number;
8481
readonly categories: CategoryList;
8582
readonly interval: Milliseconds;
86-
readonly isInverted: boolean;
8783
readonly callTreeSummaryStrategy: CallTreeSummaryStrategy;
8884
readonly ctssSamples: SamplesLikeTable;
8985
readonly ctssSampleCategoriesAndSubcategories: SampleCategoriesAndSubcategories;
@@ -336,7 +332,6 @@ class FlameGraphImpl
336332
callTreeSummaryStrategy,
337333
categories,
338334
interval,
339-
isInverted,
340335
innerWindowIDToPageMap,
341336
weightType,
342337
ctssSamples,
@@ -403,7 +398,6 @@ class FlameGraphImpl
403398
onDoubleClick: this._onCallNodeEnterOrDoubleClick,
404399
shouldDisplayTooltips: this._shouldDisplayTooltips,
405400
interval,
406-
isInverted,
407401
ctssSamples,
408402
ctssSampleCategoriesAndSubcategories,
409403
tracedTiming: tracedTimingNonInverted,
@@ -450,7 +444,6 @@ export const FlameGraph = explicitConnectWithForwardRef<
450444
selectedThreadSelectors.getRightClickedCallNodeIndex(state),
451445
scrollToSelectionGeneration: getScrollToSelectionGeneration(state),
452446
interval: getProfileInterval(state),
453-
isInverted: getInvertCallstack(state),
454447
callTreeSummaryStrategy:
455448
selectedThreadSelectors.getCallTreeSummaryStrategy(state),
456449
innerWindowIDToPageMap: getInnerWindowIDToPageMap(state),

0 commit comments

Comments
 (0)