Better tables.

Author: mstange

src/components/app/BenchmarkCompareViewer.css

@@ -1,13 +1,14 @@
 .benchmarkCompareViewer {
-  width: 95%;
-  max-width: 1400px;
+  flex: 1;
   box-sizing: border-box;
+  width: 100%;
+  min-height: 100%;
   padding: 2em 3em;
-  border: 1px solid var(--home-border-color);
-  border-radius: 3px;
-  margin: auto;
   background: var(--base-background-color);
-  box-shadow: 0 5px 25px var(--home-shadow-color);
+}
+
+.benchmarkResults {
+  font-size: 14px;
 }
 
 .benchmarkTitle {
@@ -94,10 +95,18 @@
   margin-bottom: 1em;
   border-collapse: collapse;
   font-size: 0.9em;
+
+  /* Fixed layout so the numeric column widths are honored exactly. With
+   * the same numeric widths in both the outer score table and the inner
+   * subtest tables, and zero right-padding on the expansion row, the
+   * numeric columns line up vertically across both tables. The first
+   * column (label / bucket name) flexes to fill the remaining space. */
+  table-layout: fixed;
 }
 
 .benchmarkTable th,
 .benchmarkTable td {
+  box-sizing: border-box;
   padding: 4px 8px;
   border-bottom: 1px solid var(--grey-20);
   text-align: left;
@@ -112,18 +121,18 @@
   font-weight: bold;
 }
 
-.benchmarkTable--buckets td {
-  max-width: 0;
-}
-
 .benchmarkCell--number {
   font-variant-numeric: tabular-nums;
   text-align: right;
 }
 
-.benchmarkCell--bucketName {
+.benchmarkCell--colFixed {
+  width: 9rem;
+}
+
+.benchmarkCell--bucketName,
+.benchmarkCell--scoreLabel {
   overflow: hidden;
-  max-width: 400px;
   text-overflow: ellipsis;
 }
 
@@ -136,26 +145,74 @@
   padding-left: 1.5em;
 }
 
-/* Color coding — high confidence: colored background + bold */
+/* Expandable subtest rows in the score table */
+
+.benchmarkRow--suite-expandable {
+  cursor: pointer;
+}
+
+.benchmarkRow--suite-expandable:hover {
+  background: var(--grey-10);
+}
+
+.benchmarkCell--suiteLabel {
+  position: relative;
+}
+
+.benchmarkDisclosure {
+  display: inline-block;
+  width: 1em;
+  margin-right: 0.25em;
+  color: var(--grey-60);
+  font-size: 0.75em;
+  text-align: center;
+  user-select: none;
+}
+
+.benchmarkRow--expansion > td {
+  padding: 0.5em 0 0.5em 2.5em;
+  background: var(--grey-10);
+}
+
+.benchmarkRow--expansion .benchmarkTable {
+  margin-bottom: 0;
+}
+
+/* Color coding.
+ *
+ * Confidence drives shading (background): HIGH = full, MEDIUM = muted,
+ * LOW = no shading. Effect size drives boldness: Large = bold,
+ * Moderate = semibold, Small/Negligible = normal.
+ */
 
 .benchmarkCell--regressed {
-  background: var(--red-10, #ffe8e8);
   color: var(--red-70, #a4000f);
-  font-weight: bold;
 }
 
 .benchmarkCell--improved {
-  background: var(--green-10, #d3f3d8);
   color: var(--green-80, #006504);
-  font-weight: bold;
 }
 
-/* Medium confidence: muted background only, no bold, no colored text */
+.benchmarkCell--regressed.benchmarkCell--conf-high {
+  background: var(--red-10, #ffe8e8);
+}
 
-.benchmarkCell--regressed-medium {
+.benchmarkCell--regressed.benchmarkCell--conf-medium {
   background: color-mix(in srgb, var(--red-10, #ffe8e8) 40%, transparent);
 }
 
-.benchmarkCell--improved-medium {
+.benchmarkCell--improved.benchmarkCell--conf-high {
+  background: var(--green-10, #d3f3d8);
+}
+
+.benchmarkCell--improved.benchmarkCell--conf-medium {
   background: color-mix(in srgb, var(--green-10, #d3f3d8) 40%, transparent);
 }
+
+.benchmarkCell--effect-large {
+  font-weight: bold;
+}
+
+.benchmarkCell--effect-moderate {
+  font-weight: 600;
+}