Skip to content

Commit aad804f

Browse files
committed
Pass callNodeInfo to handleCallNodeTransformShortcut.
1 parent d23f03c commit aad804f

7 files changed

Lines changed: 11 additions & 7 deletions

File tree

src/actions/profile-view.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2101,6 +2101,7 @@ export function closeBottomBox(): ThunkAction<void> {
21012101
export function handleCallNodeTransformShortcut(
21022102
event: React.KeyboardEvent<HTMLElement>,
21032103
threadsKey: ThreadsKey,
2104+
callNodeInfo: CallNodeInfo,
21042105
callNodeIndex: IndexIntoCallNodeTable
21052106
): ThunkAction<void> {
21062107
return (dispatch, getState) => {
@@ -2109,7 +2110,6 @@ export function handleCallNodeTransformShortcut(
21092110
}
21102111
const threadSelectors = getThreadSelectorsFromThreadsKey(threadsKey);
21112112
const unfilteredThread = threadSelectors.getThread(getState());
2112-
const callNodeInfo = threadSelectors.getCallNodeInfo(getState());
21132113
const implementation = getImplementationFilter(getState());
21142114
const inverted = getInvertCallstack(getState());
21152115
const callNodePath = callNodeInfo.getCallNodePathFromIndex(callNodeIndex);

src/components/calltree/CallTree.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@ class CallTreeImpl extends PureComponent<Props> {
192192
rightClickedCallNodeIndex,
193193
handleCallNodeTransformShortcut,
194194
threadsKey,
195+
callNodeInfo,
195196
} = this.props;
196197
const nodeIndex =
197198
rightClickedCallNodeIndex !== null
@@ -200,7 +201,7 @@ class CallTreeImpl extends PureComponent<Props> {
200201
if (nodeIndex === null) {
201202
return;
202203
}
203-
handleCallNodeTransformShortcut(event, threadsKey, nodeIndex);
204+
handleCallNodeTransformShortcut(event, threadsKey, callNodeInfo, nodeIndex);
204205
};
205206

206207
_onEnterOrDoubleClick = (nodeId: IndexIntoCallNodeTable) => {

src/components/calltree/FunctionList.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ class FunctionListImpl extends PureComponent<Props> {
164164
// selectedFunctionIndex,
165165
// rightClickedFunctionIndex,
166166
// threadsKey,
167+
// callNodeInfo,
167168
// } = this.props;
168169
// const nodeIndex =
169170
// rightClickedFunctionIndex !== null
@@ -172,7 +173,7 @@ class FunctionListImpl extends PureComponent<Props> {
172173
// if (nodeIndex === null) {
173174
// return;
174175
// }
175-
// handleCallNodeTransformShortcut(event, threadsKey, nodeIndex);
176+
// handleCallNodeTransformShortcut(event, threadsKey, callNodeInfo, nodeIndex);
176177
};
177178

178179
_onEnterOrDoubleClick = (_nodeId: IndexIntoFuncTable) => {

src/components/calltree/LowerWing.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,7 @@ class LowerWingImpl extends PureComponent<Props> {
186186
selectedCallNodeIndex,
187187
rightClickedCallNodeIndex,
188188
handleCallNodeTransformShortcut,
189+
callNodeInfo,
189190
threadsKey,
190191
} = this.props;
191192
const nodeIndex =
@@ -195,7 +196,7 @@ class LowerWingImpl extends PureComponent<Props> {
195196
if (nodeIndex === null) {
196197
return;
197198
}
198-
handleCallNodeTransformShortcut(event, threadsKey, nodeIndex);
199+
handleCallNodeTransformShortcut(event, threadsKey, callNodeInfo, nodeIndex);
199200
};
200201

201202
_onEnterOrDoubleClick = (nodeId: IndexIntoCallNodeTable) => {

src/components/calltree/UpperWing.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,7 @@ class UpperWingImpl extends PureComponent<Props> {
186186
selectedCallNodeIndex,
187187
rightClickedCallNodeIndex,
188188
handleCallNodeTransformShortcut,
189+
callNodeInfo,
189190
threadsKey,
190191
} = this.props;
191192
const nodeIndex =
@@ -195,7 +196,7 @@ class UpperWingImpl extends PureComponent<Props> {
195196
if (nodeIndex === null) {
196197
return;
197198
}
198-
handleCallNodeTransformShortcut(event, threadsKey, nodeIndex);
199+
handleCallNodeTransformShortcut(event, threadsKey, callNodeInfo, nodeIndex);
199200
};
200201

201202
_onEnterOrDoubleClick = (nodeId: IndexIntoCallNodeTable) => {

src/components/flame-graph/FlameGraph.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ class FlameGraphImpl
302302
return;
303303
}
304304

305-
handleCallNodeTransformShortcut(event, threadsKey, nodeIndex);
305+
handleCallNodeTransformShortcut(event, threadsKey, callNodeInfo, nodeIndex);
306306
};
307307

308308
_onCopy = (event: ClipboardEvent) => {

src/components/stack-chart/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ class StackChartImpl extends React.PureComponent<Props> {
177177
return;
178178
}
179179

180-
handleCallNodeTransformShortcut(event, threadsKey, nodeIndex);
180+
handleCallNodeTransformShortcut(event, threadsKey, callNodeInfo, nodeIndex);
181181
};
182182

183183
_onDoubleClick = (callNodeIndex: IndexIntoCallNodeTable | null) => {

0 commit comments

Comments
 (0)