Skip to content

Commit cef92f1

Browse files
committed
fix(FilterNavigatorBar): clip overflow so many breadcrumbs do not expand the parent
Without overflow: hidden the bar's intrinsic min-content width (sum of all nowrap children) propagates up through the flex column parent and makes the flame-graph tab grow horizontally past the viewport. With many breadcrumbs the tab ends up around 15k px wide and gains a horizontal scrollbar. Items inside the bar already have text-overflow: ellipsis on .filterNavigatorBarItemContent, so clipping at the bar level is the intended behaviour. The original comment noted that overflow was omitted to preserve a fade-out animation on items at the end; that animation has since been removed, so the constraint no longer applies. Closes #6028
1 parent fe5f9f0 commit cef92f1

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

src/components/shared/FilterNavigatorBar.css

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
--internal-separator-img: url(../../../res/img/svg/scope-bar-separator.svg);
1313

1414
display: flex;
15+
overflow: hidden;
1516
height: 24px;
1617
flex-flow: row nowrap;
1718
flex-shrink: 0;
@@ -20,9 +21,10 @@
2021
cursor: default;
2122
user-select: none;
2223

23-
/* Note: no overflow: hidden for historical reasons - we wanted to see
24-
an animation for items at the end while they were fading out, but
25-
we have removed this animation in the meantime */
24+
/* Without overflow: hidden, the bar's intrinsic min-content width (sum of
25+
all nowrap children) propagates up and forces the parent flame-graph tab
26+
to expand horizontally past the viewport when there are many breadcrumbs
27+
(issue #6028). Items already truncate text via .filterNavigatorBarItemContent. */
2628
}
2729

2830
:root.dark-mode {

0 commit comments

Comments
 (0)