Skip to content

Split getSelfAndTotal. #6113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mstange merged 2 commits into from
Jun 23, 2026
+26 −15
Merged

Split getSelfAndTotal. #6113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f08129
Split getSelfAndTotal.
mstange Jun 21, 2026
309336c
Merge branch 'main' into push-ytvwpwmsmzlm
mstange Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 26 additions & 15 deletions src/profile-logic/call-tree.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,8 @@ interface CallTreeInternal {
hasChildren(callNodeIndex: IndexIntoCallNodeTable): boolean;
createChildren(nodeIndex: IndexIntoCallNodeTable): CallNodeChildren;
createRoots(): CallNodeChildren;
getSelfAndTotal(nodeIndex: IndexIntoCallNodeTable): SelfAndTotal;
getSelf(nodeIndex: IndexIntoCallNodeTable): number;
getTotal(nodeIndex: IndexIntoCallNodeTable): number;
findHeaviestPathInSubtree(
callNodeIndex: IndexIntoCallNodeTable
): CallNodePath;
Expand Down Expand Up @@ -171,10 +172,12 @@ export class CallTreeInternalNonInverted implements CallTreeInternal {
return this._callNodeHasChildren[callNodeIndex] !== 0;
}

getSelfAndTotal(callNodeIndex: IndexIntoCallNodeTable): SelfAndTotal {
const self = this._callTreeTimings.self[callNodeIndex];
const total = this._callTreeTimings.total[callNodeIndex];
return { self, total };
getSelf(callNodeIndex: IndexIntoCallNodeTable): number {
return this._callTreeTimings.self[callNodeIndex];
}

getTotal(callNodeIndex: IndexIntoCallNodeTable): number {
return this._callTreeTimings.total[callNodeIndex];
}

findHeaviestPathInSubtree(
Expand Down Expand Up @@ -216,11 +219,12 @@ export class CallTreeInternalFunctionList implements CallTreeInternal {
return this._timings.sortedFuncs;
}

getSelfAndTotal(nodeIndex: IndexIntoCallNodeTable): SelfAndTotal {
return {
self: this._timings.funcSelf[nodeIndex],
total: this._timings.funcTotal[nodeIndex],
};
getSelf(nodeIndex: IndexIntoCallNodeTable): number {
return this._timings.funcSelf[nodeIndex];
}

getTotal(nodeIndex: IndexIntoCallNodeTable): number {
return this._timings.funcTotal[nodeIndex];
}

findHeaviestPathInSubtree(
Expand Down Expand Up @@ -288,13 +292,19 @@ class CallTreeInternalInverted implements CallTreeInternal {
return children;
}

getSelfAndTotal(callNodeIndex: IndexIntoCallNodeTable): SelfAndTotal {
getSelf(callNodeIndex: IndexIntoCallNodeTable): number {
if (this._callNodeInfo.isRoot(callNodeIndex)) {
return this._totalPerRootFunc[callNodeIndex];
}
return 0;
}

getTotal(callNodeIndex: IndexIntoCallNodeTable): number {
if (this._callNodeInfo.isRoot(callNodeIndex)) {
const total = this._totalPerRootFunc[callNodeIndex];
return { self: total, total };
return this._totalPerRootFunc[callNodeIndex];
}
const { total } = this._getTotalAndHasChildren(callNodeIndex);
return { self: 0, total };
return total;
}

_getTotalAndHasChildren(
Expand Down Expand Up @@ -445,7 +455,8 @@ export class CallTree {
this._thread.funcTable.name[funcIndex]
);

const { self, total } = this._internal.getSelfAndTotal(callNodeIndex);
const total = this._internal.getTotal(callNodeIndex);
const self = this._internal.getSelf(callNodeIndex);
const totalRelative = total / this._rootTotalSummary;
const selfRelative = self / this._rootTotalSummary;

Expand Down
Loading