Skip to content

Pass callNodeInfo to handleCallNodeTransformShortcut.#6115

Merged
mstange merged 2 commits into
firefox-devtools:mainfrom
mstange:push-txtmsmxrmyqq
Jun 23, 2026
Merged

Pass callNodeInfo to handleCallNodeTransformShortcut.#6115
mstange merged 2 commits into
firefox-devtools:mainfrom
mstange:push-txtmsmxrmyqq

Conversation

@mstange

@mstange mstange commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

The function handleCallNodeTransformShortcut takes a call node index as a parameter, but it was getting the call node info separately from a selector. At the moment that's fine because this is always the right call node info.

But once we add separate call node infos for things like "the callees of the selected function in the function list", the two might get out of sync, so it's better to pass the correct call node info that is compatible with the passed call node index.

Functionally-neutral change.

The function handleCallNodeTransformShortcut takes a call node index
as a parameter, but it was getting the call node info separately from
a selector. At the moment that's fine because this is always the right
call node info.

But once we add separate call node infos for things like "the callees
of the selected function in the function list", the two might get out
of sync, so it's better to pass the correct call node info that is
compatible with the passed call node index.

Functionally-neutral change.
@mstange mstange requested review from canova and fatadel June 22, 2026 15:15
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.45%. Comparing base (81b3bdb) to head (2cfc425).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6115      +/-   ##
==========================================
- Coverage   83.45%   83.45%   -0.01%     
==========================================
  Files         341      341              
  Lines       36074    36073       -1     
  Branches    10106    10001     -105     
==========================================
- Hits        30107    30106       -1     
  Misses       5539     5539              
  Partials      428      428              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mstange mstange enabled auto-merge June 23, 2026 13:41
@mstange mstange merged commit 02df99b into firefox-devtools:main Jun 23, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants