Skip to content
This repository was archived by the owner on Jul 23, 2024. It is now read-only.

Commit 440f3b7

Browse files
author
daisuke
committed
Rename element variable
1 parent bd15cc4 commit 440f3b7

1 file changed

Lines changed: 17 additions & 17 deletions

File tree

extension/sidebar-pane.js

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ async function _update() {
1515
}
1616

1717
async function _updateSelectedNode(selectedNode) {
18-
const ulEl = document.querySelector("#selected ul");
18+
const issueListEl = document.querySelector("#selected ul");
1919

2020
if (!_isValidElement(selectedNode)) {
21-
_render([], ulEl);
21+
_render([], issueListEl);
2222
return;
2323
}
2424

@@ -34,15 +34,15 @@ async function _updateSelectedNode(selectedNode) {
3434
..._webcompat.getCSSDeclarationBlockIssues(declarations, _targetBrowsers));
3535
}
3636

37-
_render(issues, ulEl);
37+
_render(issues, issueListEl);
3838
}
3939

4040
async function _updateSubtree(selectedNode) {
4141
const subtreeEl = document.getElementById("subtree");
42-
const ulEl = subtreeEl.querySelector("ul");
42+
const issueListEl = subtreeEl.querySelector("ul");
4343

4444
if (!_isValidElement(selectedNode)) {
45-
_render([], ulEl);
45+
_render([], issueListEl);
4646
return;
4747
}
4848

@@ -75,7 +75,7 @@ async function _updateSubtree(selectedNode) {
7575
}
7676

7777
progressEl.textContent = "Rendering all issues";
78-
_render(issues, ulEl);
78+
_render(issues, issueListEl);
7979

8080
subtreeEl.classList.remove("processing");
8181
}
@@ -84,30 +84,30 @@ function _isValidElement({ nodeType, isCustomElement }) {
8484
return nodeType === Node.ELEMENT_NODE && !isCustomElement;
8585
}
8686

87-
function _render(issues, ulEl) {
88-
ulEl.innerHTML = "";
87+
function _render(issues, issueListEl) {
88+
issueListEl.innerHTML = "";
8989

9090
if (!issues.length) {
91-
const liEl = document.createElement("li");
92-
liEl.textContent = "No issues";
93-
ulEl.appendChild(liEl);
91+
const noIssueEl = document.createElement("li");
92+
noIssueEl.textContent = "No issues";
93+
issueListEl.appendChild(noIssueEl);
9494
} else {
9595
for (const issue of issues) {
96-
ulEl.appendChild(_renderIssue(issue));
96+
issueListEl.appendChild(_renderIssue(issue));
9797
}
9898
}
9999
}
100100

101101
function _renderIssue(issue) {
102-
const liEl = document.createElement("li");
102+
const issueEl = document.createElement("li");
103103
const subjectEl = _renderSubject(issue);
104104
const predicateEl = _renderPredicate(issue);
105-
liEl.appendChild(subjectEl);
106-
liEl.appendChild(predicateEl);
105+
issueEl.appendChild(subjectEl);
106+
issueEl.appendChild(predicateEl);
107107

108-
liEl.classList.add((issue.deprecated ? "warning" : "information"));
108+
issueEl.classList.add((issue.deprecated ? "warning" : "information"));
109109

110-
return liEl;
110+
return issueEl;
111111
}
112112

113113
function _renderSubject(issue) {

0 commit comments

Comments
 (0)