Commit 6855da8
fix: GitHubUpdateChecker JSON property naming mismatch
GitHub REST API uses snake_case (tag_name, html_url, browser_download_url)
but the deserializer used JsonNamingPolicy.CamelCase which expected
tagName/htmlUrl. All properties deserialized to null, release.TagName
was empty, and CheckAsync always returned IsUpdateAvailable=false — the
update banner has never actually fired since F-008 added the checker.
Replace the policy with explicit JsonPropertyName attributes on each
property in GitHubRelease and GitHubAsset records. Verified against the
live API: latest release tag is now parsed and IsUpdateAvailable is
true when the installed version is older.
Note: users still running pre-fix builds will not see the banner; one
manual MSI install of the next release is required to roll the fix out.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 010ecae commit 6855da8
1 file changed
Lines changed: 17 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
87 | 88 | | |
88 | 89 | | |
89 | 90 | | |
| 91 | + | |
90 | 92 | | |
| 93 | + | |
| 94 | + | |
91 | 95 | | |
| 96 | + | |
| 97 | + | |
92 | 98 | | |
| 99 | + | |
| 100 | + | |
93 | 101 | | |
| 102 | + | |
| 103 | + | |
94 | 104 | | |
95 | 105 | | |
96 | 106 | | |
97 | 107 | | |
98 | 108 | | |
| 109 | + | |
99 | 110 | | |
| 111 | + | |
| 112 | + | |
100 | 113 | | |
101 | 114 | | |
102 | 115 | | |
0 commit comments