[BHP1-1546] Add Optimized Contain Diagram#236
Conversation
|
Impressive work! I appreciate how you also included the VMS work to make this more extensible in the future. Testing the worksheet you provided looks good, and when I tested another worksheet to ensure backwards compatibility, that looked good as well (see: Surf&Contain-ContainmentDiagram-Issue.bp7.zip ). Please take care of the following linting errors: projects/behave/src/cljs/behave/components/results/diagrams.cljsL88-123 - What do you think of turning this into a separate function that outputs projects/behave/src/cljs/behave/worksheet/events.cljsL824 - Should this use a translation key? |
|
hmm seems to be some missing inputs in save file you provided I created a new file on dev This does indeed show me only half the ellipse on this branch: |


Purpose
SIGContainAdapter::doContainRunWithOptimalResourceto now also process a range of simulations after the optimal production rate has been computed and ensure getters for the points are now exposed in wasmRelated Issues
Closes BHP1-1546
Submission Checklist
BHP1-### <title>)clj-kondo --lint components/**/src bases/**/src projects/**/src)clojure -M:compile-cljs)Testing
Open local vms and run migration script
migrations.2026-05-11-add-optimized-contain-diagramIn VMS, Navigate to Contain Module page
Verify there is now a new accordion for Diagrams
Verify there are now 2 contain diagrams, select edit to view the form of attributes a user can update
Open local App and sync vms
Open this worksheet:
BHP1-1546.zip
Re-run this worksheet
Navigate to results page and verify there is a new diagram for the Production Rate vs Containment area diagram
Screenshot