Skip to content

Net: honor listen=0 for embedded Tor#1830

Draft
cursor[bot] wants to merge 2 commits into
masterfrom
cursor/critical-bug-inspection-c1c8
Draft

Net: honor listen=0 for embedded Tor#1830
cursor[bot] wants to merge 2 commits into
masterfrom
cursor/critical-bug-inspection-c1c8

Conversation

@cursor
Copy link
Copy Markdown
Contributor

@cursor cursor Bot commented May 1, 2026

PR intention

Fix a regression where -listen=0 -torsetup=1 still bound a dedicated local listener for embedded Tor hidden-service forwarding. This made the node accept inbound onion traffic even though parameter interaction had disabled listening/listenonion.

Code changes brief

  • Gate the embedded Tor dedicated onion listener on the effective -listen setting, while preserving explicit -listenonion=1 behavior.
  • Add a proxy_test.py regression check that starts -listen=0 -torsetup=1 and verifies no extra loopback onion listener is bound.

Validation:

  • python3 -m py_compile qa/rpc-tests/proxy_test.py
  • Regex sanity check for the new log assertion
  • Full functional test not run: no build artifacts or depends toolchain were present in the workspace.
Open in Web View Automation 

cursoragent and others added 2 commits May 1, 2026 08:09
Co-authored-by: Reuben Yap <reuben@firo.org>
Co-authored-by: Reuben Yap <reuben@firo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant