FCE-3368: Android ForegroundService should take a importance flag#49
Merged
MiloszFilimowski merged 3 commits intoMay 27, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the React Native foreground-service API to allow callers to control notification “loudness” via an importance flag, and fixes Android notification taps so they reopen the host app instead of doing nothing.
Changes:
- Added optional
importance?: 'low' | 'high'toForegroundServiceConfigand forwarded it to the native module. - Android foreground service now maps
importancetoNotificationChannelimportance andNotificationCompatpriority (defaulting tohigh). - Android notification tap now targets the app’s launcher activity via
getLaunchIntentForPackage(...)with an immutablePendingIntent.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/useForegroundService.ts | Adds importance to the JS/TS config and forwards it to native. |
| android/src/main/java/com/oney/WebRTCModule/foregroundService/WebRTCForegroundService.java | Applies importance to notification priority/channel importance and fixes notification tap intent. |
| android/src/main/java/com/oney/WebRTCModule/foregroundService/ForegroundServiceController.java | Reads importance from the RN config (default high) and passes it to the service intent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
importance?: 'low' | 'high'toForegroundServiceConfig;WebRTCForegroundServicemaps the value toNotificationChannelimportance andNotificationCompatpriority viachannelImportanceFor/builderPriorityForhelpers. Defaults to
'high'when omitted (current behavior).Intentwas passed toPendingIntent.getActivity(...), which had noactivity component to resolve, so the tap silently did nothing.
PendingIntenttoFLAG_IMMUTABLEand addedFLAG_ACTIVITY_SINGLE_TOP | FLAG_ACTIVITY_CLEAR_TOPso the existing task is reused instead ofstacked.
Motivation and Context
The foreground-service notification was always loud (
IMPORTANCE_HIGH) and tapping it did nothing - both made the background-call indicator unnecessarily intrusive andbroken. Exposing
importancelets consumers opt into a silent ongoing-call style, and the launcher fix restores the expected "tap to return to the app"