Skip to content

FCE-3458: Extract Audio to JS from WebRTC (Part 1 — vendor miniaudio)#57

Merged
MiloszFilimowski merged 2 commits into
masterfrom
mfilimowski/FCE-3458-audio-extraction-part1
Jun 22, 2026
Merged

FCE-3458: Extract Audio to JS from WebRTC (Part 1 — vendor miniaudio)#57
MiloszFilimowski merged 2 commits into
masterfrom
mfilimowski/FCE-3458-audio-extraction-part1

Conversation

@MiloszFilimowski

Copy link
Copy Markdown
Collaborator

Description

  • Vendors miniaudio v0.11.25 as a single-header C library (common/cpp/vendor/miniaudio.h/.c)
  • Adds NOTICE file with the full miniaudio dual-license (Public Domain / MIT-0)
  • miniaudio is built in conversion-only mode (MA_NO_DEVICE_IO, MA_NO_DECODING, etc.) — no audio I/O, just PCM resampling and format conversion

Motivation and Context

Part 1 of 2 for the audio extraction feature. Isolated into its own PR because miniaudio adds ~96K lines of vendored source and would otherwise dominate the feature diff. Part 2 (the actual audio extraction implementation) stacks on this.

Documentation impact

  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

Adds the miniaudio single-header C library used for PCM resampling and
format conversion in the audio extraction feature (Part 2).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 22, 2026 08:41
@linear

linear Bot commented Jun 22, 2026

Copy link
Copy Markdown

FCE-3458

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 4 changed files in this pull request and generated no new comments.

@MiloszFilimowski MiloszFilimowski merged commit f75b126 into master Jun 22, 2026
8 checks passed
@MiloszFilimowski MiloszFilimowski deleted the mfilimowski/FCE-3458-audio-extraction-part1 branch June 22, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants