Skip to content

Commit 396718e

Browse files
MagmusacyCopilotMiloszFilimowski
authored
Make iOS bundle id agnostic (#486)
## Description Made changes to describe how to build the example app ## Motivation and Context bundleIdentifier on iOS was tied to fishjam and wouldn't build on real device for people outside of fishjam org ## Documentation impact - [ ] Documentation update required - [ ] Documentation updated [in another PR](_) - [X] No documentation update required ## Types of changes - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Miłosz Filimowski <MiloszFilimowski@users.noreply.github.com>
1 parent 347b6b1 commit 396718e

1 file changed

Lines changed: 15 additions & 0 deletions

File tree

examples/mobile-client/fishjam-chat/README.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,18 @@ yarn
3636
yarn build
3737
```
3838

39+
> [!IMPORTANT]
40+
> Before prebuilding, replace all occurrences of `io.fishjam.example.fishjamchat` in `app.json` with your own bundle identifier:
41+
>
42+
> - **iOS bundle identifier**`expo.ios.bundleIdentifier`
43+
> - **Android package name**`expo.android.package`
44+
>
45+
> For example, if your bundle ID is `com.yourcompany.yourapp`:
46+
>
47+
> - iOS & Android: `com.yourcompany.yourapp`
48+
> - ScreenBroadcastExtension: `com.yourcompany.yourapp.ScreenBroadcastExtension`
49+
> - App group: `group.com.yourcompany.yourapp`
50+
3951
3. Prebuild native files in example directory:
4052

4153
```sh
@@ -56,10 +68,13 @@ yarn android
5668
## Development
5769

5870
1. Whenever you make changes in the `packages` directory, make sure to build the app in the root directory (not in `examples/mobile-client/fishjam-chat`). This ensures that all related workspaces are also built:
71+
5972
```sh
6073
yarn build
6174
```
75+
6276
2. Linter (run in the root directory):
77+
6378
```sh
6479
yarn lint
6580
```

0 commit comments

Comments
 (0)