Commit 81737da
authored
Fix client not setting msid for camera video tracks (#518)
## Description
Root cause: createSimulcastTransceiverConfig in transceivers.ts was
missing the streams field in its
return object. Audio and non-simulcast video both had it, but simulcast
video did not so the browser
sent the simulcast track with no stream ID in the SDP (a=msid:- ...),
causing the server to see streams:
[] for the video track while audio got the correct stream ID.
## Motivation and Context
Why is this change required? What problem does it solve? If it fixes an
open
issue, please link to the issue here.
## Documentation impact
- [ ] Documentation update required
- [ ] Documentation updated [in another PR](_)
- [x] No documentation update required
## Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to
not work as expected)1 parent b68ff22 commit 81737da
2 files changed
Lines changed: 28 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
| 102 | + | |
102 | 103 | | |
103 | 104 | | |
104 | 105 | | |
| |||
Lines changed: 27 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
2 | 3 | | |
3 | | - | |
| 4 | + | |
| 5 | + | |
4 | 6 | | |
| 7 | + | |
5 | 8 | | |
6 | 9 | | |
7 | 10 | | |
| |||
51 | 54 | | |
52 | 55 | | |
53 | 56 | | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
54 | 80 | | |
55 | 81 | | |
56 | 82 | | |
| |||
0 commit comments