Skip to content

Commit 95cc16e

Browse files
invert track manager order (#532)
## Description - Swap order in `FishjamProvider` so `audioTrackManager` initializes before `videoTrackManager` - Bump `@fishjam-cloud/react-native-webrtc` to `0.26.2` in `mobile-client` ## Motivation and Context Audio track must register first to fix track manager ordering (FCE-3304). ## Documentation impact - [ ] Documentation update required - [ ] Documentation updated [in another PR](_) - [x] No documentation update required ## Types of changes - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
1 parent e516146 commit 95cc16e

3 files changed

Lines changed: 16 additions & 16 deletions

File tree

packages/mobile-client/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,15 @@
4040
]
4141
},
4242
"peerDependencies": {
43-
"@fishjam-cloud/react-native-webrtc": "0.26.0",
43+
"@fishjam-cloud/react-native-webrtc": "0.26.2",
4444
"expo": "*",
4545
"react": "*",
4646
"react-native": "*",
4747
"react-native-get-random-values": "1.11.0"
4848
},
4949
"dependencies": {
5050
"@fishjam-cloud/react-client": "workspace:*",
51-
"@fishjam-cloud/react-native-webrtc": "0.26.0",
51+
"@fishjam-cloud/react-native-webrtc": "0.26.2",
5252
"fast-text-encoding": "1.0.6",
5353
"react-native-get-random-values": "1.11.0",
5454
"react-native-url-polyfill": "3.0.0"

packages/react-client/src/FishjamProvider.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -100,23 +100,23 @@ export function FishjamProvider(props: FishjamProviderProps) {
100100
[props.bandwidthLimits],
101101
);
102102

103-
const videoTrackManager = useTrackManager({
103+
const audioTrackManager = useTrackManager({
104104
tsClient: fishjamClientRef.current,
105105
peerStatus,
106-
deviceManager: cameraManager,
106+
deviceManager: microphoneManager,
107107
bandwidthLimits: mergedBandwidthLimits,
108-
streamConfig: props.videoConfig,
109-
type: "camera",
108+
streamConfig: props.audioConfig,
109+
type: "microphone",
110110
logger,
111111
});
112112

113-
const audioTrackManager = useTrackManager({
113+
const videoTrackManager = useTrackManager({
114114
tsClient: fishjamClientRef.current,
115115
peerStatus,
116-
deviceManager: microphoneManager,
116+
deviceManager: cameraManager,
117117
bandwidthLimits: mergedBandwidthLimits,
118-
streamConfig: props.audioConfig,
119-
type: "microphone",
118+
streamConfig: props.videoConfig,
119+
type: "camera",
120120
logger,
121121
});
122122

yarn.lock

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3397,7 +3397,7 @@ __metadata:
33973397
resolution: "@fishjam-cloud/react-native-client@workspace:packages/mobile-client"
33983398
dependencies:
33993399
"@fishjam-cloud/react-client": "workspace:*"
3400-
"@fishjam-cloud/react-native-webrtc": "npm:0.26.0"
3400+
"@fishjam-cloud/react-native-webrtc": "npm:0.26.2"
34013401
eslint-config-expo: "npm:~9.2.0"
34023402
eslint-import-resolver-typescript: "npm:^3.10.1"
34033403
eslint-plugin-prettier: "npm:^5.5.1"
@@ -3407,23 +3407,23 @@ __metadata:
34073407
react-native-url-polyfill: "npm:3.0.0"
34083408
typescript: "npm:^5.8.3"
34093409
peerDependencies:
3410-
"@fishjam-cloud/react-native-webrtc": 0.26.0
3410+
"@fishjam-cloud/react-native-webrtc": 0.26.2
34113411
expo: "*"
34123412
react: "*"
34133413
react-native: "*"
34143414
react-native-get-random-values: 1.11.0
34153415
languageName: unknown
34163416
linkType: soft
34173417

3418-
"@fishjam-cloud/react-native-webrtc@npm:0.26.0":
3419-
version: 0.26.0
3420-
resolution: "@fishjam-cloud/react-native-webrtc@npm:0.26.0"
3418+
"@fishjam-cloud/react-native-webrtc@npm:0.26.2":
3419+
version: 0.26.2
3420+
resolution: "@fishjam-cloud/react-native-webrtc@npm:0.26.2"
34213421
dependencies:
34223422
base64-js: "npm:1.5.1"
34233423
debug: "npm:4.3.4"
34243424
peerDependencies:
34253425
react-native: "*"
3426-
checksum: 10c0/392370fa8f477df81b3eaf12ae39d28000fd17b79784d18bba49d07314ae62546efa3f634f215514c77c55efd5f244aaa3a94fb7e08579f81d552db418cd1e03
3426+
checksum: 10c0/7dc36b2dd356362a14e4c348a5dc2f0b0f163cc962c3ad7e0d5db7d0e2233417d33aaf44ad78bcfdec550117f834bbb2644efc9b0a01a58381b95fa2f3f35f25
34273427
languageName: node
34283428
linkType: hard
34293429

0 commit comments

Comments
 (0)