Skip to content

Commit bcdae4b

Browse files
authored
fix: fetch submodule tags before checking webrtc release tag (#553)
## Motivation and Context ``` check:webrtc-published fails on CI but passes locally check-webrtc-published.mjs runs git -C packages/react-native-webrtc describe --exact-match --tags HEAD. That only works if the submodule's tags are present in .git. - Locally it passes because the dev has previously fetched the submodule's tags. - On GH Actions actions/checkout@v4 with submodules: recursive checks out the submodule at the pinned SHA but does not fetch its tags, so git describe finds nothing → "Submodule HEAD (6b994c0) is not at a tagged release". ``` ## Documentation impact - [ ] Documentation update required - [ ] Documentation updated [in another PR](_) - [x] No documentation update required ## Types of changes - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
1 parent 5fc0185 commit bcdae4b

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

release-automation/check-webrtc-published.mjs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,15 @@ try {
2727
);
2828
}
2929

30+
// CI checkout omits submodule tags, so fetch them before describe.
31+
try {
32+
execSync(`git -C "${submoduleDir}" fetch --tags --quiet`, {
33+
stdio: ["ignore", "ignore", "ignore"],
34+
});
35+
} catch {
36+
// best effort: tags may already be present locally
37+
}
38+
3039
let tagAtHead;
3140
try {
3241
tagAtHead = execSync(

0 commit comments

Comments
 (0)