Fix local VAD flickering on cleanup#520
Merged
MiloszFilimowski merged 1 commit intoApr 24, 2026
Merged
Conversation
clearTimeout alone cannot cancel an already-running poll awaiting getLocalTrackAudioLevel. Pending promise resolved after cleanup, calling setIsSpeaking and scheduling new timeout — caused flickering. AbortSignal short-circuits poll at each await boundary.
MiloszFilimowski
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
useLocalVADpollsgetLocalTrackAudioLevelin asetTimeoutloop. On cleanup it callsclearTimeout, but that can't cancel a poll that's already mid-await. The in-flight promise still resolves aftercleanup runs, calls
setIsSpeaking, and schedules a freshsetTimeoutsoisSpeakingflickers and the poll loop leaks past the disabled state.Fix: added an
AbortControllerand checksignal.abortedaround eachawaitboundary. The poll exits cleanly on cleanup and won't schedule another timeout.Motivation and Context
isSpeakingwas flickering when the hook got toggled off or the component unmounted, and a stale poll could keep running against aborted state. Users saw the speaking indicator flash briefly after goingsilent or leaving the room.
Documentation impact
Types of changes
not work as expected)