Skip to content

FCE-3229 add general set received track quality method#524

Merged
czerwiukk merged 2 commits into
mainfrom
FCE-3229/add-setReceivedTrackQuality-method
Apr 28, 2026
Merged

FCE-3229 add general set received track quality method#524
czerwiukk merged 2 commits into
mainfrom
FCE-3229/add-setReceivedTrackQuality-method

Conversation

@czerwiukk

@czerwiukk czerwiukk commented Apr 27, 2026

Copy link
Copy Markdown
Member

Description

Adds a general setReceivedTracksQuality method to usePeers hook.

Motivation and Context

The track.setReceivedQuality method usage gets tricky if you want to use it in useEffect.
Adding a general method resolves this by separating the function from the state.

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@czerwiukk czerwiukk self-assigned this Apr 27, 2026
@linear

linear Bot commented Apr 27, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a stable, general-purpose setReceivedTrackQuality function to the usePeers hook so consumers can change received track quality without relying on per-track methods that are awkward to use in useEffect.

Changes:

  • Add setReceivedTrackQuality callback to usePeers.
  • Update the usePeers return object/documentation to expose the new method (and remove the legacy peers alias).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/react-client/src/hooks/usePeers.ts Outdated
Comment thread packages/react-client/src/hooks/usePeers.ts Outdated
@czerwiukk czerwiukk force-pushed the FCE-3229/add-setReceivedTrackQuality-method branch from a8667f5 to 21995dd Compare April 27, 2026 09:46
@czerwiukk czerwiukk force-pushed the FCE-3229/add-setReceivedTrackQuality-method branch from 21995dd to 9293b30 Compare April 27, 2026 10:07
@czerwiukk czerwiukk requested review from sgfn April 27, 2026 11:12
@czerwiukk czerwiukk requested a review from Karolk99 April 28, 2026 10:29
@czerwiukk czerwiukk merged commit 798efc1 into main Apr 28, 2026
2 checks passed
@czerwiukk czerwiukk deleted the FCE-3229/add-setReceivedTrackQuality-method branch April 28, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants