FCE-3229 add general set received track quality method#524
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a stable, general-purpose setReceivedTrackQuality function to the usePeers hook so consumers can change received track quality without relying on per-track methods that are awkward to use in useEffect.
Changes:
- Add
setReceivedTrackQualitycallback tousePeers. - Update the
usePeersreturn object/documentation to expose the new method (and remove the legacypeersalias).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a8667f5 to
21995dd
Compare
21995dd to
9293b30
Compare
Karolk99
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a general
setReceivedTracksQualitymethod tousePeershook.Motivation and Context
The
track.setReceivedQualitymethod usage gets tricky if you want to use it inuseEffect.Adding a general method resolves this by separating the function from the state.
Documentation impact
Types of changes
not work as expected)