fix(react-client): await pending addTrack to fix track ops race#527
Merged
czerwiukk merged 1 commit intoMay 6, 2026
Merged
Conversation
czerwiukk
approved these changes
May 6, 2026
czerwiukk
left a comment
Member
There was a problem hiding this comment.
rebase and check if the tests pass, code itself looks good
4c2c04b to
f37828b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
getCurrentTrackIdnow awaits the in-flightaddTrackpromise beforereturning, so callers always see the resolved remote track id once the
track is registered.
connectionPromiseRefstoring the activeaddTrackjobgetCurrentTrackIdasync and await pending jobreplaceTrack,refreshStreamedTrack,toggleMute,toggleDevice) to await the new async signaturepauseStreamingintoggleDeviceMotivation and Context
startStreamingsetcurrentTrackIdRef.currentonly afteraddTrackresolved. If the user invoked
toggleMute,replaceTrack, ortoggleDeviceduring that window,getCurrentTrackIdreturnednulland the operation silently no-op'd (mute toggles ignored, replace
skipped). Awaiting the pending promise removes the race.
Documentation impact
Types of changes
not work as expected)