Skip to content

[FCE-3270] fix(ts-client): serialize receiveMediaEvent calls #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Critteros wants to merge 4 commits into from
Closed

[FCE-3270] fix(ts-client): serialize receiveMediaEvent calls #528

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9bf4bec
fix(ts-client): serialize receiveMediaEvent calls
Critteros May 6, 2026
65255b4
Merge branch 'main' into fix/serialize-receive-media-event
czerwiukk May 6, 2026
0a66b50
Update packages/ts-client/src/FishjamClient.ts
Critteros May 6, 2026
02e0196
Merge branch 'main' into fix/serialize-receive-media-event
czerwiukk May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/ts-client/src/FishjamClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ export class FishjamClient<PeerMetadata = GenericMetadata, ServerMetadata = Gene

private reconnectManager: ReconnectManager<PeerMetadata, ServerMetadata>;
private peerMessageQueue: MessageQueue;
private receiveMediaEventChain: Promise<void> = Promise.resolve();

private sendStatisticsInterval: NodeJS.Timeout | undefined = undefined;

Expand Down Expand Up @@ -230,7 +231,12 @@ export class FishjamClient<PeerMetadata = GenericMetadata, ServerMetadata = Gene
} else if (data.authRequest) {
this.logger.warn('Received unexpected control message: authRequest');
} else if (serverMediaEvent) {
this.webrtc?.receiveMediaEvent(ServerMediaEvent.encode(serverMediaEvent).finish());
const encodedEvent = ServerMediaEvent.encode(serverMediaEvent).finish();
this.receiveMediaEventChain = this.receiveMediaEventChain
.catch((e) => {
this.logger.warn(`receiveMediaEvent failed: ${e}`);
})
.finally(() => this.webrtc?.receiveMediaEvent(encodedEvent));
}
} catch (e) {
this.logger.warn(`Received invalid control message, error: ${e}`);
Expand Down Expand Up @@ -977,6 +983,7 @@ export class FishjamClient<PeerMetadata = GenericMetadata, ServerMetadata = Gene
}
this.websocket = null;
this.webrtc = null;
this.receiveMediaEventChain = Promise.resolve();
this.cameraStream = new MediaStream();
this.screenShareStream = new MediaStream();
this.trackIdToTrack.clear();
Expand Down
Loading