FCE-3321 throw missing sandbox url error when calling methods#534
Merged
czerwiukk merged 1 commit intoMay 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts useSandbox error timing so a missing sandboxApiUrl error is thrown when sandbox backend methods are invoked (rather than when the hook is created), improving ergonomics for consumers that conditionally call sandbox APIs.
Changes:
- Introduces a dedicated
MissingSandboxApiUrlErrorerror type. - Moves the “missing sandboxApiUrl” failure from
useSandboxinitialization into each backend-calling method in the hook.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/react-client/src/utils/errors.ts | Adds MissingSandboxApiUrlError for a more specific missing-config failure. |
| packages/react-client/src/hooks/useSandbox.ts | Defers missing sandboxApiUrl failures to the point where sandbox methods are called. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
19
to
21
| export const useSandbox = (props: UseSandboxProps) => { | ||
| const sandboxApiUrl = props?.sandboxApiUrl; | ||
|
|
||
| if (!sandboxApiUrl) { | ||
| throw new Error("useSandbox requires a sandboxApiUrl, you can get it at: https://fishjam.io/app/sandbox"); | ||
| } | ||
| const sandboxApiUrl = props.sandboxApiUrl; | ||
|
|
Comment on lines
22
to
+25
| const getSandboxPeerToken = useCallback( | ||
| async (roomName: string, peerName: string, roomType: RoomType = "conference") => { | ||
| if (!sandboxApiUrl) throw new MissingSandboxApiUrlError(); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the no sandbox url error to the moment user calls the backend.
Documentation impact
Types of changes
not work as expected)