Release/1.9.0 by fivetran-avinash · Pull Request #213 · fivetran/dbt_quickbooks

fivetran-avinash · 2026-06-24T22:17:27Z

PR Overview

Package version introduced in this PR:

1.9.0

This PR addresses the following Issue/Feature(s):

QuickBooks tax lines completion

Summary of changes:

Merged into a final branch.

Submission Checklist

Alignment meeting with the reviewer (if needed)
- Timeline and validation requirements discussed
Provide validation details:
- Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
- Testing Instructions: Confirm the change addresses the issue(s)
- Focus Areas: Complex logic or queries that need extra attention
Merge any relevant open PRs into this PR

Changelog

Draft changelog for PR
Final changelog for release review

* Feature re: remaining tax lines * Resolve outstanding issues * Testing tax lines * Schema * Take out tax line variable, will bring in later * Changelog, docs * Generate dbt docs via GitHub Actions * Fix compilation error * table/table doc additions --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…ed data Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…books into release/1.9.0

fivetran-joemarkiewicz

A few change requests and open questions before approval.

fivetran-joemarkiewicz · 2026-07-08T15:56:26Z

I noticed we're not looking up any tax account in this model. Whereas the other models leveraging the tax lines join in the tax payable account to use here.

This logic currently is using the same account_id as the normal double entry method. I don't presume that's what we want to use in the tax line case.

This was a miss from the first implementation. Updated to align with the other tax lines.

fivetran-joemarkiewicz · 2026-07-08T16:08:24Z

I worry these joins could cause fan out. This tax line section also seems to behave differently from the other tax line implementations (such as bill). Is this accurate?

Removed these joins.

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

fivetran-avinash

@fivetran-joemarkiewicz Changes applied. Redshift Buildkite is taking a long time (I'm still in the queue), but everything else passed, so this is good for re-review.

fivetran-avinash · 2026-07-08T17:27:15Z

This was a miss from the first implementation. Updated to align with the other tax lines.

fivetran-avinash · 2026-07-08T17:27:23Z

Removed these joins.

fivetran-joemarkiewicz

A few final change requests before approving

fivetran-joemarkiewicz · 2026-07-08T20:39:40Z

The changes in this model need to be documented in the CHANGELOG

Good catch. Row added to schema/data changes.

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

fivetran-avinash

@fivetran-joemarkiewicz changes applied, ready for final review

fivetran-avinash · 2026-07-08T22:07:08Z

Good catch. Row added to schema/data changes.

fivetran-joemarkiewicz

Approved with a few small requests

fivetran-joemarkiewicz · 2026-07-08T22:15:46Z

+| ------------- | ----------- | --- | --- | ----- |
+| All tax line models | Variable configuration (opt-in) | Individual tax line variables sufficient | `quickbooks__tax_lines_enabled: true` also required | **Potential breaking change for dbt Core users** If you previously enabled any individual tax line variables, those models will now be disabled by default. See the [Enabling Tax Lines](https://github.com/fivetran/dbt_quickbooks/tree/main#enabling-tax-lines) section of the README for configuration details.  |
+| `quickbooks__general_ledger` | Potential new rows | No tax lines | Tax lines now available (opt-in) | Tax line rows are disabled by default. Set `quickbooks__tax_lines_enabled: true` and enable individual tax line variables to post tax lines to the tax liability account. Tax lines are added only when you opt in. See the [Enabling Tax Lines](https://github.com/fivetran/dbt_quickbooks/tree/main#enabling-tax-lines) section of the README for details. |
+| `int_quickbooks__purchase_double_entry` | Data change | `paid_to_account_id` = purchase line expense account; `class_id` = expense class from purchase line | `paid_to_account_id` = tax liability account; `class_id` = `null` | **Potential breaking change** for users with `using_purchase_tax_line: true`. Tax lines now correctly post to the tax liability account. `class_id` is no longer populated for tax line rows. |


This is only relevant if the individual tax line table is enabled and quickbooks__tax_lines_enabled: true. Let's add the clarification.

Thanks for calling that out, updated.

fivetran-joemarkiewicz · 2026-07-10T20:44:12Z

+[PR #213](https://github.com/fivetran/dbt_quickbooks/pull/213) includes the following updates:
+
+## Schema/Data Change
+**12 total changes • 3 possible breaking changes**


In the sections below we use interchangeably "potential" and "possible" for breaking change callouts. Can you update either way to have consistent verbiage.

Standardized.

Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>

@fivetran-catfritz

* feature/exchange-gain-loss * fixes * decisionlog * yml * Apply suggestion from @fivetran-catfritz * ad some aliases * convert to full * Generate dbt docs via GitHub Actions * update vars * update docs * Generate dbt docs via GitHub Actions * Apply suggestions from code review Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com> Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com> * fix seed ids * fix seed dupes * put the seeds back * restore seeds again * restore seeds again * restore seeds again * update col seed types * Generate dbt docs via GitHub Actions * merge conflicts * Update CHANGELOG with tax line model changes Updated the CHANGELOG to reflect changes in tax line models and potential breaking changes for users. Added details about enabling tax lines and configuration requirements. * Update CHANGELOG.md * Revise CHANGELOG for new features and updates Updated the CHANGELOG to reflect new features and updates regarding tax lines and exchange gain/loss entries. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

fivetran-jamie

Approved pending one item

fivetran-jamie · 2026-07-13T19:53:12Z

+| All tax line models | Variable configuration (opt-in) | Individual tax line variables sufficient | `quickbooks__tax_lines_enabled: true` also required | **Possible breaking change for dbt Core users** If you previously enabled any individual tax line variables, those models will now be disabled by default. See the [Enabling Tax Lines](https://github.com/fivetran/dbt_quickbooks/tree/main#enabling-tax-lines) section of the README for configuration details.  |
+| `quickbooks__general_ledger` | Potential new rows | No tax lines | Tax lines now available (opt-in) | Tax line rows are disabled by default. Set `quickbooks__tax_lines_enabled: true` and enable individual tax line variables to post tax lines to the tax liability account. Tax lines are added only when you opt in. See the [Enabling Tax Lines](https://github.com/fivetran/dbt_quickbooks/tree/main#enabling-tax-lines) section of the README for details. |
+| `int_quickbooks__purchase_double_entry` | Data change | `paid_to_account_id` = purchase line expense account; `class_id` = expense class from purchase line | `paid_to_account_id` = tax liability account; `class_id` = `null` | **Possible breaking change** for users with `using_purchase_tax_line: true` and `quickbooks__tax_lines_enabled: true`. Tax lines now correctly post to the tax liability account. `class_id` is no longer populated for tax line rows. |
+| `currency_id`, `exchange_rate`, `quantity`, `sales_item_quantity` in several header staging tables | Explicit type cast | Warehouse-native type | `string` / `float` | **Possible breaking change** for downstream consumers with type-sensitive logic built on staging models. |


string / float is a lil confusing -- are some fields strings and others floats?

@fivetran-jamie Yep. Updated to make it clearer.

fivetran-avinash and others added 7 commits June 24, 2026 13:13

version bump

4c25380

Merge in 1.8.1

a297171

pull in latest updates

9d6f83b

Tax lines on Quickstart

0a1957e

Revert seeds to main; replace new tax-line seeds with actionable join…

e526b37

…ed data Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Revert seeds

8f1bfc4

fivetran-avinash marked this pull request as ready for review July 7, 2026 19:23

fivetran-avinash self-assigned this Jul 7, 2026

fivetran-catfritz and others added 4 commits July 7, 2026 16:35

update seed col types

2ab5925

Validation test fixes

6ffd8f9

Merge branch 'release/1.9.0' of https://github.com/fivetran/dbt_quick…

ad88c18

…books into release/1.9.0

dbt_project.yml

4460a55

fivetran-avinash added the docs:ready Triggers the docs generator workflow. label Jul 8, 2026

github-actions Bot and others added 3 commits July 8, 2026 08:57

Generate dbt docs via GitHub Actions

a2e5472

New source relation

0422f0c

Merge branch 'release/1.9.0' of https://github.com/fivetran/dbt_quick…

2b8ee19

…books into release/1.9.0

fivetran-joemarkiewicz requested changes Jul 8, 2026

View reviewed changes

fivetran-avinash and others added 3 commits July 8, 2026 09:20

Apply suggestions from code review

acff7d3

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

PR changes

1dbb213

PR changes

5182e4a

fivetran-avinash commented Jul 8, 2026

View reviewed changes

fivetran-joemarkiewicz requested changes Jul 8, 2026

View reviewed changes

fivetran-avinash and others added 3 commits July 8, 2026 14:41

Apply suggestions from code review

40980fd

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

PR requests

07a6435

PR requests + batch updates

2ab71af

fivetran-avinash commented Jul 8, 2026

View reviewed changes

float64 casting

99c19de

fivetran-joemarkiewicz approved these changes Jul 10, 2026

View reviewed changes

Apply suggestions from code review

899b2ce

Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>

fivetran-avinash and others added 3 commits July 10, 2026 15:31

CHANGELOG

a6e7ecc

CHANGELOG

6788d8c

fivetran-catfritz added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Jul 11, 2026

github-actions Bot and others added 2 commits July 11, 2026 01:06

Generate dbt docs via GitHub Actions

f4a9796

Release final checks

adb7e9a

fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Jul 13, 2026

fivetran-avinash assigned fivetran-catfritz Jul 13, 2026

Generate dbt docs via GitHub Actions

93c51c5

fivetran-jamie approved these changes Jul 13, 2026

View reviewed changes

Changelog tweak

362607d

fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Jul 13, 2026

Generate dbt docs via GitHub Actions

1efaf15

fivetran-avinash merged commit cf1867c into main Jul 13, 2026
9 checks passed

Uh oh!

Conversation

fivetran-avinash commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Overview

Submission Checklist

Changelog

Uh oh!

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fivetran-avinash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-jamie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash commented Jun 24, 2026 •

edited

Loading

fivetran-avinash Jul 13, 2026 •

edited

Loading