fix(review): address Copilot feedback for setup and diagnostics

Author: GitHub Copilot CLI

.devcontainer/Dockerfile

@@ -52,7 +52,7 @@ RUN --mount=type=cache,target=/tmp/npm-cache \
     wait && \
     # ECC ajv依存関係修正（既知の問題対応）
     ECC_DIR=$(npm list -g ecc-universal 2>/dev/null | head -n1 | awk '{print $1}')/node_modules/ecc-universal && \
-    if [[ -d "$ECC_DIR" ]]; then \
+    if [ -d "$ECC_DIR" ]; then \
         cd "$ECC_DIR" && npm install ajv 2>/dev/null || true; \
     fi && \
     # グローバル ajv もインストール（フォールバック）
@@ -62,7 +62,7 @@ RUN --mount=type=cache,target=/tmp/npm-cache \
 FROM dev-tools AS final
 
 # VSCode ユーザー作成（条件付き - DevContainer対応）
-RUN if ! id "vscode" &>/dev/null; then \
+RUN if ! id "vscode" >/dev/null 2>&1; then \
         useradd -m -s /bin/bash vscode; \
     fi && \
     usermod -aG sudo vscode 2>/dev/null || true && \

.devcontainer/entrypoint.sh

@@ -2,8 +2,18 @@
 
 echo "🔧 OpenCode ECC DevContainer エントリーポイント"
 
+is_valid_tailscale_key() {
+    local key
+    key=$(echo "$1" | tr -d '"' | tr -d '[:space:]')
+    [[ "$key" =~ ^tskey-auth- ]] || return 1
+    [[ "$key" == "your-tailscale-auth-key-here" ]] && return 1
+    [[ "$key" == "tskey-auth-xxxxxxxxxxxxxxxxx" ]] && return 1
+    [[ "$key" =~ ^tskey-auth-[xX]+$ ]] && return 1
+    return 0
+}
+
 # Tailscale daemon 起動
-if [ -n "$TAILSCALE_AUTH_KEY" ]; then
+if is_valid_tailscale_key "$TAILSCALE_AUTH_KEY"; then
     echo "🌐 Tailscale daemon 起動中..."
     sudo tailscaled --statedir=/var/lib/tailscale --socket=/run/tailscale/tailscaled.sock &
 fi

.devcontainer/setup.sh

@@ -83,9 +83,6 @@ mkdir -p ~/.opencode ~/.opencode/.agents ~/.opencode/.agents/skills
 sudo chown -R vscode:vscode ~/.opencode 2>/dev/null || chown -R vscode:vscode ~/.opencode 2>/dev/null || true
 chmod -R 755 ~/.opencode 2>/dev/null || true
 
-# ホームディレクトリ全体の権限確認（念のため）
-sudo chown -R vscode:vscode /home/vscode 2>/dev/null || chown -R vscode:vscode /home/vscode 2>/dev/null || true
-
 # ajv 依存関係エラー修正（既知の問題）
 echo "   🔧 ajv 依存関係修正中..."
 ECC_PATH=$(npm list -g ecc-universal 2>/dev/null | head -n1 | awk '{print $1}' || echo "")

.devcontainer/startup.sh

@@ -23,7 +23,10 @@ if [ -f "/workspace/.env" ]; then
 fi
 
 sanitize_opencode_agents() {
-    local agents_dir="/home/vscode/.opencode/agents"
+    local agents_dir="/home/vscode/.opencode/.agents"
+    if [ ! -d "$agents_dir" ] && [ -d "/home/vscode/.opencode/agents" ]; then
+        agents_dir="/home/vscode/.opencode/agents"
+    fi
     [ -d "$agents_dir" ] || return 0
 
     local changed=0

.devcontainer/validate-setup.sh

@@ -54,7 +54,12 @@ run_test ".env.template ファイル存在確認" "test -f /workspace/.env.templ
 
 if [[ -f "/workspace/.env" ]]; then
     source /workspace/.env 2>/dev/null || true
-    run_test "TAILSCALE_AUTH_KEY 設定確認" "test -n '$TAILSCALE_AUTH_KEY' && test '$TAILSCALE_AUTH_KEY' != 'your-tailscale-auth-key-here'"
+    if [[ -n "$TAILSCALE_AUTH_KEY" && "$TAILSCALE_AUTH_KEY" != "your-tailscale-auth-key-here" && "$TAILSCALE_AUTH_KEY" != "tskey-auth-xxxxxxxxxxxxxxxxx" ]]; then
+        run_test "TAILSCALE_AUTH_KEY 設定確認" "test -n '$TAILSCALE_AUTH_KEY'"
+    else
+        echo -e "${YELLOW}🔍 [${TESTS_TOTAL}+1] TAILSCALE_AUTH_KEY 設定確認 (オプション)${NC}"
+        echo -e "${YELLOW}   ⚠️  SKIP（ローカルモード許容）${NC}"
+    fi
     run_test "ECC_PROFILE 設定確認" "test -n '$ECC_PROFILE'"
 fi
 
@@ -162,7 +167,7 @@ echo ""
 echo -e "${BLUE}🔄 統合テスト（簡易）${NC}"
 
 if [[ -n "$TAILSCALE_AUTH_KEY" && "$TAILSCALE_AUTH_KEY" != "your-tailscale-auth-key-here" ]]; then
-    run_test "Tailscale 認証テスト" "timeout 10 tailscale up --auth-key='$TAILSCALE_AUTH_KEY' --reset"
+    run_test "Tailscale 認証テスト" "timeout 10 tailscale --socket=/run/tailscale/tailscaled.sock up --auth-key='$TAILSCALE_AUTH_KEY' --reset"
 fi
 
 # テスト結果サマリー

scripts/diagnose-devcontainer.sh

@@ -41,12 +41,12 @@ if command -v tailscale >/dev/null 2>&1; then
     fi
 
     # Check Tailscale status
-    if sudo tailscale status >/dev/null 2>&1; then
+    if sudo tailscale --socket=/run/tailscale/tailscaled.sock status >/dev/null 2>&1; then
         echo "  ✅ Tailscale 接続確認済み"
-        sudo tailscale status | head -3 | sed 's/^/     /'
+        sudo tailscale --socket=/run/tailscale/tailscaled.sock status | head -3 | sed 's/^/     /'
     else
         echo "  ⚠️  Tailscale 未接続または未認証"
-        echo "     認証コマンド: sudo tailscale up --auth-key=YOUR_KEY"
+        echo "     認証コマンド: sudo tailscale --socket=/run/tailscale/tailscaled.sock up --auth-key=YOUR_KEY"
     fi
 else
     echo "  ❌ Tailscale 未インストール"
@@ -119,7 +119,7 @@ if ! grep -q "127.0.0.1.*$(hostname)" /etc/hosts 2>/dev/null; then
 fi
 
 if ! pgrep -x tailscaled >/dev/null && command -v tailscale >/dev/null 2>&1; then
-    echo "  2. Tailscaled 起動: sudo tailscaled --tun=userspace-networking --socks5-server=localhost:1055 &"
+    echo "  2. Tailscaled 起動: sudo tailscaled --statedir=/var/lib/tailscale --socket=/run/tailscale/tailscaled.sock --tun=userspace-networking --socks5-server=localhost:1055 &"
 fi
 
 if [ ! -f ".env" ]; then

scripts/fix-permissions.sh

@@ -44,10 +44,8 @@ mkdir -p "$HOME/.opencode/config"
 echo "   🔑 所有権設定中..."
 if command -v sudo >/dev/null 2>&1; then
     sudo chown -R vscode:vscode "$HOME/.opencode" 2>/dev/null || chown -R vscode:vscode "$HOME/.opencode" 2>/dev/null || true
-    sudo chown -R vscode:vscode "$HOME" 2>/dev/null || chown -R vscode:vscode "$HOME" 2>/dev/null || true
 else
     chown -R vscode:vscode "$HOME/.opencode" 2>/dev/null || true
-    chown -R vscode:vscode "$HOME" 2>/dev/null || true
 fi
 
 # 3. パーミッション設定