[Triton] Integrate reorder-loop-loads into LoopUnroll pass#775
Open
isaname wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
After loop unrolling with
tl.range(loop_unroll_factor=N), load and compute operations are interleaved in the loop body. This prevents optimal memory pipelineutilization — ideally all loads should be issued early to overlap with subsequent computation.
Previously a standalone
TritonReorderLoopLoadspass handled post-unroll load clustering. This PR merges that logic directly into theLoopUnrollpass, performingreordering in-place immediately after unrolling, eliminating the extra pass and simplifying the pipeline.
Design
1. Reorder logic integrated into LoopUnroll
For loops with
tt.reorderattribute:Key helpers:
willFullyUnroll()(static trip count check),collectDepsInBlock()(transitive dep collection),reorderLoadsInRange()(load-first reorderingpreserving relative order within each group).
2. User interface
Added
reorder=Falseparameter totl.range. Whenreorder=Truewithloop_unroll_factorset, thett.reorderattribute is attached to thescf.for, triggeringload clustering during unroll.
Performance
cp_gather_indexer_k_quant_cache
fused_inv_rope_fp8_quant