refactor: improvements and issues#22
Merged
Merged
Conversation
dieppa
force-pushed
the
fixes-improvements
branch
from
0954597 to
db989d5
Compare
dieppa
requested changes
Mar 17, 2026
Member
There was a problem hiding this comment.
-
Missing test coverage for Issue 3 (null option values): checkNullOptionValues() is called in 5 validators (CreateIndex, Insert, Update, CreateView, RenameCollection), but tests only
cover 3 of them (CreateIndex, Insert, Update). CreateView and RenameCollection null option value tests are missing. I'd recommend adding those two tests for completeness.DONE
Everything else is solid — guard ordering in RenameCollectionOperator is correct, helper precondition patterns are consistent, static lookup map is properly initialized and immutable,
and collation building now uses the same type-safe helpers as the rest of the mapper layer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: improvements and issues