fix: some PR comments

Author: bercianor

core/flamingock-core/src/main/java/io/flamingock/internal/core/builder/runner/CliRunner.java

@@ -92,7 +92,9 @@ public void run() {
 
     private void writeResponse(AbstractOperationResult result, Throwable error, long durationMs) {
         ResponseEnvelope envelope;
-        String operationName = flamingockArgs.getOperation().isPresent() ? flamingockArgs.getOperation().get().name() : "unknown";
+        String operationName = flamingockArgs.getOperation()
+            .map(Enum::name)
+            .orElse("unknown");
 
         if (error != null) {
             envelope = ResponseEnvelope.failure(operationName, ResponseError.from(error), durationMs);

core/flamingock-core/src/main/java/io/flamingock/internal/core/operation/AbstractPipelineTraverseOperation.java

@@ -85,6 +85,23 @@ public AbstractPipelineTraverseOperation(RunnerId runnerId,
         this.finalizer = finalizer;
     }
 
+    protected abstract boolean validateOnlyMode();
+
+    @Override
+    public ExecuteResult execute(ExecuteArgs args) {
+        ExecuteResponseData result;
+        try {
+            result = this.execute(args.getPipeline());
+        } catch (OperationException operationException) {
+            throw operationException;
+        } catch (Throwable throwable) {
+            throw processAndGetFlamingockException(throwable, null);
+        } finally {
+            this.finalizer.run();
+        }
+        return new ExecuteResult(result);
+    }
+
     private static List<AbstractLoadedStage> validateAndGetExecutableStages(LoadedPipeline pipeline) {
         pipeline.validate();
         List<AbstractLoadedStage> stages = new ArrayList<>();
@@ -95,7 +112,7 @@ private static List<AbstractLoadedStage> validateAndGetExecutableStages(LoadedPi
         return stages;
     }
 
-    protected ExecuteResponseData execute(LoadedPipeline pipeline, Boolean validateOnly) throws FlamingockException {
+    protected ExecuteResponseData execute(LoadedPipeline pipeline) throws FlamingockException {
         List<AbstractLoadedStage> allStages = validateAndGetExecutableStages(pipeline);
         int stageCount = allStages.size();
         long changeCount = allStages.stream()
@@ -114,7 +131,7 @@ protected ExecuteResponseData execute(LoadedPipeline pipeline, Boolean validateO
                 execution.validate();
 
                 if (execution.isExecutionRequired()) {
-                    if (validateOnly) {
+                    if (validateOnlyMode()) {
                         throw new PendingChangesException();
                     }
                     execution.applyOnEach((executionId, lock, executableStage) -> {

core/flamingock-core/src/main/java/io/flamingock/internal/core/operation/execute/ExecuteApplyOperation.java

@@ -15,10 +15,8 @@
  */
 package io.flamingock.internal.core.operation.execute;
 
-import io.flamingock.internal.common.core.response.data.ExecuteResponseData;
 import io.flamingock.internal.core.event.EventPublisher;
 import io.flamingock.internal.core.operation.AbstractPipelineTraverseOperation;
-import io.flamingock.internal.core.operation.OperationException;
 import io.flamingock.internal.core.pipeline.execution.*;
 import io.flamingock.internal.core.plan.ExecutionPlanner;
 import io.flamingock.internal.util.id.RunnerId;
@@ -39,18 +37,7 @@ public ExecuteApplyOperation(RunnerId runnerId,
     }
 
     @Override
-    public ExecuteResult execute(ExecuteArgs args) {
-        ExecuteResponseData result;
-        try {
-            result = this.execute(args.getPipeline(), false);
-        } catch (OperationException operationException) {
-            result = operationException.getResult();
-            throw operationException;
-        } catch (Throwable throwable) {
-            throw processAndGetFlamingockException(throwable, null);
-        } finally {
-            finalizer.run();
-        }
-        return new ExecuteResult(result);
+    protected boolean validateOnlyMode() {
+        return false;
     }
 }

core/flamingock-core/src/main/java/io/flamingock/internal/core/operation/validate/ValidateOperation.java

@@ -15,13 +15,9 @@
  */
 package io.flamingock.internal.core.operation.validate;
 
-import io.flamingock.internal.common.core.error.FlamingockException;
 import io.flamingock.internal.common.core.error.PendingChangesException;
-import io.flamingock.internal.common.core.response.data.ExecuteResponseData;
 import io.flamingock.internal.core.event.EventPublisher;
 import io.flamingock.internal.core.operation.AbstractPipelineTraverseOperation;
-import io.flamingock.internal.core.operation.execute.ExecuteArgs;
-import io.flamingock.internal.core.operation.execute.ExecuteResult;
 import io.flamingock.internal.core.pipeline.execution.OrphanExecutionContext;
 import io.flamingock.internal.core.pipeline.execution.StageExecutor;
 import io.flamingock.internal.core.plan.ExecutionPlanner;
@@ -44,17 +40,7 @@ public ValidateOperation(RunnerId runnerId,
     }
 
     @Override
-    public ExecuteResult execute(ExecuteArgs args) {
-        ExecuteResponseData result;
-        try {
-            result = super.execute(args.getPipeline(), true);
-        } catch (FlamingockException flamingockException) {
-            throw flamingockException;
-        } catch (Throwable throwable) {
-            throw new FlamingockException(throwable);
-        } finally {
-            super.finalizer.run();
-        }
-        return new ExecuteResult(result);
+    protected boolean validateOnlyMode() {
+        return true;
     }
 }