Flamingock importing from mongock 4

[hhvitek]

Importing Mongock 4 audit history fails on missing "type" field

Is Mongock 4 supported as a starting point for the Flamingock importer, or only Mongock 5? Flamingock 1.2.0 currently crashes on my setup Mongock 4 era audit collection at startup:

org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'flamingock-runner' defined in class path resource [io/flamingock/springboot/FlamingockAutoConfiguration.class]: java.lang.NullPointerException: Name is null

Caused by: java.lang.NullPointerException: Name is null
	at java.base/java.lang.Enum.valueOf(Enum.java:291) ~[?:?]
	at io.flamingock.importer.mongock.mongodb.MongockAuditEntry$MongockChangeType.valueOf(MongockAuditEntry.java:201) ~[mongock-importer-mongodb-1.2.0.jar:?]
	at io.flamingock.importer.mongock.mongodb.MongockAuditEntry.<init>(MongockAuditEntry.java:59) ~[mongock-importer-mongodb-1.2.0.jar:?]
	at io.flamingock.importer.mongock.mongodb.MongockImporterMongoDB.toChangeEntry(MongockImporterMongoDB.java:100) ~[mongock-importer-mongodb-1.2.0.jar:?]
	at io.flamingock.importer.mongock.mongodb.MongockImporterMongoDB.toAuditEntry(MongockImporterMongoDB.java:52) ~[mongock-importer-mongodb-1.2.0.jar:?]

My existing audit document collections (written by Mongock 4) have no "type" field - only "state".

Is there a supported way to migrate Mongock 4 audit history to Mongock 5 shape before letting Flamingock import it? If I manually backfill type = "EXECUTION" on all existing entries manually i move to another exception

Caused by: java.lang.NullPointerException: Cannot invoke "java.lang.Boolean.booleanValue()" because the return value of "io.flamingock.importer.mongock.mongodb.MongockAuditEntry.getSystemChange()" is null
	at io.flamingock.importer.mongock.mongodb.MongockImporterMongoDB.toAuditEntry(MongockImporterMongoDB.java:74) ~[mongock-importer-mongodb-1.2.0.jar:?]
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:214) ~[?:?]
	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1716) ~[?:?]
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:570) ~[?:?]
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:560) ~[?:?]
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921) ~[?:?]
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:265) ~[?:?]
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:723) ~[?:?]
	at io.flamingock.importer.mongock.mongodb.MongockImporterMongoDB.getAuditHistory(MongockImporterMongoDB.java:47) ~[mongock-importer-mongodb-1.2.0.jar:?]
	at io.flamingock.support.mongock.MongockImportChange.importHistory(MongockImportChange.java:60) ~[mongock-support-1.2.0.jar:?]
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) ~[?:?]
	at java.base/java.lang.reflect.Method.invoke(Method.java:565) ~[?:?]
	at io.flamingock.internal.core.runtime.ExecutionRuntime.executeMethodWithParameters(ExecutionRuntime.java:120) ~[flamingock-core-1.2.0.jar:?]
	at io.flamingock.internal.core.runtime.ExecutionRuntime.executeMethodWithInjectedDependencies(ExecutionRuntime.java:115) ~[flamingock-core-1.2.0.jar:?]
	at io.flamingock.internal.core.task.executable.CodeExecutableTask.executeInternal(CodeExecutableTask.java:65) ~[flamingock-core-1.2.0.jar:?]

[osantana85]

Hi @hhvitek , thanks for reporting this.

At the moment, the Mongock importer has mainly been tested against Mongock v5+ audit history. Mongock v4 audit documents have a slightly different shape, and as you found, some fields expected by the current importer, such as ⁠ type ⁠ and ⁠ systemChange ⁠, may not exist in v4 entries.

So, to answer your question, Mongock v4 is not fully supported yet as a starting point for the Flamingock importer in 1.3.0.

We’ll take this into account for a next version and add support for Mongock v4 audit history migration.

In the meantime, if you want to continue with the migration now, you can backfill the existing Mongock audit entries with the missing fields before running Flamingock:

type = "EXECUTION"
systemChange = false

We haven't tested it, but that should let the current migration process continue with Mongock v4 audit data.

Thanks again for the detailed stack trace; it clearly points to the missing v4 compatibility layer.