Commit 0183364
committed
fix(cli): commit built webapp/dist so go:embed build passes in CI
A stray `pkg/cli/webapp/dist/` line in .gitignore re-ignored the directory
after the negations meant to keep it tracked (last-match-wins), so nothing
under dist was committed. CI's `go build ./cmd/captain` then failed with
`pattern all:webapp/dist: no matching files found`, which also broke the
test and lint jobs' compilation.
The webapp can't be built in CI or the goreleaser release job (its vite
build uses a local clicky-ui link: dependency), so the built dist must be
committed and embedded. Remove the contradictory ignore line, commit the
production dist, and correct serve.go's stale comment.1 parent fa146f4 commit 0183364
148 files changed
Lines changed: 924 additions & 4 deletions
File tree
- pkg/cli
- webapp/dist
- assets
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | 23 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | | - | |
31 | | - | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
32 | 34 | | |
33 | 35 | | |
34 | 36 | | |
| |||
Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments