Skip to content

Commit 32ab5af

Browse files
committed
ci(e2e): fix ginkgo args, bump Go to 1.26 and upload-artifact to v4
- ginkgo rejects flags after the package list; use 'ginkgo run' with flags before ./e2e - bump GO_VERSION/matrix to 1.26 to match go.mod (go 1.26.1) - upgrade actions/upload-artifact v3 -> v4 (v3 is auto-failed by GitHub)
1 parent ac7d97a commit 32ab5af

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

.github/workflows/e2e.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ on:
2323
- "go.sum"
2424

2525
env:
26-
GO_VERSION: "1.22"
26+
GO_VERSION: "1.26"
2727

2828
jobs:
2929
e2e-tests:
@@ -32,7 +32,7 @@ jobs:
3232
strategy:
3333
matrix:
3434
os: [ubuntu-latest, macos-latest]
35-
go-version: ["1.22"]
35+
go-version: ["1.26"]
3636
timeout-minutes: 30
3737

3838
steps:
@@ -73,7 +73,7 @@ jobs:
7373
- name: Run E2E tests with Ginkgo
7474
run: |
7575
go install github.com/onsi/ginkgo/v2/ginkgo@latest
76-
ginkgo -v ./e2e --timeout=10m --poll-progress-after=1m
76+
ginkgo run -v --timeout=10m --poll-progress-after=1m ./e2e
7777
env:
7878
CGO_ENABLED: 1
7979
continue-on-error: false
@@ -91,14 +91,14 @@ jobs:
9191

9292
- name: Upload coverage reports
9393
if: always()
94-
uses: actions/upload-artifact@v3
94+
uses: actions/upload-artifact@v4
9595
with:
9696
name: e2e-coverage-${{ matrix.os }}
9797
path: coverage-e2e.*
9898

9999
- name: Upload test results
100100
if: always()
101-
uses: actions/upload-artifact@v3
101+
uses: actions/upload-artifact@v4
102102
with:
103103
name: e2e-test-results-${{ matrix.os }}
104104
path: |
@@ -137,14 +137,14 @@ jobs:
137137
- name: Set up Go
138138
uses: actions/setup-go@v4
139139
with:
140-
go-version: "1.22"
140+
go-version: "1.26"
141141
cache: true
142142
cache-dependency-path: go.sum
143143

144144
- name: Run E2E tests with verbose output
145145
run: |
146146
go install github.com/onsi/ginkgo/v2/ginkgo@latest
147-
ginkgo -v -r ./e2e --timeout=10m --poll-progress-after=1m
147+
ginkgo run -v -r --timeout=10m --poll-progress-after=1m ./e2e
148148
env:
149149
CGO_ENABLED: 1
150150

0 commit comments

Comments
 (0)