chore: upgrade to go 1.25

Author: moshloop

.github/workflows/lint.yml

@@ -11,7 +11,7 @@ jobs:
       - name: Install Go
         uses: buildjet/setup-go@v5
         with:
-          go-version: 1.22.x
+          go-version: 1.25.x
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v8
         with:

.github/workflows/release.yml

@@ -32,7 +32,7 @@ jobs:
       - name: Setup Go
         uses: buildjet/setup-go@v5
         with:
-          go-version: v1.22.x
+          go-version: v1.25.x
       - uses: buildjet/cache@v4
         with:
           path: |

.github/workflows/test.yml

@@ -11,8 +11,7 @@ jobs:
       matrix:
         platform: [ubuntu-latest]
         go-version:
-          - 1.23.x
-          - 1.24.x
+          - 1.25.x
     runs-on: ${{ matrix.platform }}
     steps:
       - name: Install Go

Makefile

@@ -4,9 +4,11 @@ test:
 
 .PHONY: lint
 lint:
-	golangci-lint run
+	mkdir -p bin
+	GOBIN=$(shell realpath bin) go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.4.0
+	./bin/golangci-lint run
 
 .PHONY: tidy
 tidy:
-	go mod tidy	
+	go mod tidy
 

collections/priorityqueue_test.go

@@ -217,6 +217,7 @@ var _ = Describe("PriorityQueue", func() {
 			// 500ms delayed item should not be available immediately
 			item, ok = pq.Dequeue()
 			Expect(ok).To(BeFalse())
+			Expect(item).To(BeEmpty())
 
 			// After 600ms, the 500ms delayed item should be available
 			Eventually(func() string {
@@ -246,6 +247,7 @@ var _ = Describe("PriorityQueue", func() {
 			Expect(pq.Size()).To(BeZero())
 			item, ok = pq.Dequeue()
 			Expect(ok).To(BeFalse())
+			Expect(item).To(BeEmpty())
 		})
 	})
 })

console/test_results.go

@@ -137,7 +137,7 @@ func (c *TestResults) Tracef(s string, args ...interface{}) {
 
 func (c *TestResults) Assert(name string, expect, actual interface{}) {
 	if expect == actual {
-		c.Passf(name, name)
+		c.Passf(name, "%s", name)
 	} else {
 		c.Failf(name, "expected \"%v\", got \"%vs\"", expect, actual)
 	}

go.mod

@@ -1,10 +1,9 @@
 module github.com/flanksource/commons
 
-go 1.23.0
-
-toolchain go1.23.4
+go 1.25.1
 
 require (
+	github.com/Masterminds/semver/v3 v3.4.0
 	github.com/Snawoot/go-http-digest-auth-client v1.1.3
 	github.com/bsm/gomega v1.27.10
 	github.com/emirpasic/gods/v2 v2.0.0-alpha
@@ -31,7 +30,6 @@ require (
 	github.com/shirou/gopsutil/v3 v3.24.5
 	github.com/sirupsen/logrus v1.9.3
 	github.com/spf13/pflag v1.0.6
-	github.com/stretchr/testify v1.10.0
 	github.com/ulikunitz/xz v0.5.12
 	github.com/vadimi/go-http-ntlm v1.0.3
 	github.com/vadimi/go-http-ntlm/v2 v2.5.0

go.sum

@@ -1,3 +1,5 @@
+github.com/Masterminds/semver/v3 v3.4.0 h1:Zog+i5UMtVoCU8oKka5P7i9q9HgrJeGzI9SA1Xbatp0=
+github.com/Masterminds/semver/v3 v3.4.0/go.mod h1:4V+yj/TJE1HU9XfppCwVMZq3I84lprf4nC11bSS5beM=
 github.com/Snawoot/go-http-digest-auth-client v1.1.3 h1:Xd/SNBuIUJqotzmxRpbXovBJxmlVZOT19IZZdMdrJ0Q=
 github.com/Snawoot/go-http-digest-auth-client v1.1.3/go.mod h1:WiwNiPXTRGyjTGpBtSQJlM2wDPRRPpFGhMkMWpV4uqg=
 github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=

http/request.go

@@ -245,7 +245,7 @@ func (r *Request) Debug() string {
 	var sb strings.Builder
 	sb.WriteString(fmt.Sprintf("%s %s\n", r.method, logger.StripSecrets(r.url.String())))
 	for k, v := range logger.StripSecretsFromMap(r.HeaderMap()) {
-		sb.WriteString(fmt.Sprintf("  %s: %s\n", console.Grayf(k), v))
+		sb.WriteString(fmt.Sprintf("  %s: %s\n", console.Grayf("%s", k), v))
 	}
 	body, _ := io.ReadAll(r.body)
 	sb.WriteString(logger.StripSecrets(string(body)))

http/response.go

@@ -111,7 +111,7 @@ func (h *Response) Debug() string {
 
 	sb.WriteString(fmt.Sprintf("\n====> Status: %d\n", h.StatusCode))
 	for k, v := range logger.StripSecretsFromMap(h.HeaderMap()) {
-		sb.WriteString(fmt.Sprintf("  %s: %s\n", console.Grayf(k), v))
+		sb.WriteString(fmt.Sprintf("  %s: %s\n", console.Grayf("%s", k), v))
 	}
 	if h.IsJSON() {
 		r, _ := h.AsJSON()