feat: add support for *-word-* pattern#267
Merged
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for patterns surrounded by * (e.g., *word*) in matchPattern and updates the test suite accordingly.
- Extend
matchPatternto handle patterns with both leading and trailing wildcards. - Adjust existing test and add a substring-wildcard test case.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| collections/slice.go | Added branch to match items when pattern starts and ends with * |
| collections/slice_test.go | Updated "Multiple Wildcards" case and added a *ppl* test |
Comments suppressed due to low confidence (2)
collections/slice_test.go:70
- [nitpick] The test name "Glob" is ambiguous; consider renaming to something like "Substring Wildcard" to more clearly describe what's being tested.
name: "Glob",
collections/slice_test.go:72
- Consider adding a test case for suffix-only wildcard patterns (e.g.,
app*) to ensure coverage of patterns with only a trailing*.
patterns: []string{"*ppl*"},
|
🎉 This PR is included in version 1.40.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.