chore: logging improvements#277
Merged
Merged
Conversation
When using os.OpenRoot with OpenFile, the mode parameter must only contain permission bits (0777), not the full mode with file type bits. This fixes the 'unsupported file mode' error when extracting tar archives containing files with standard Unix permissions. Changes: - Extract permission bits using os.ModePerm mask for regular files - Extract permission bits for hard links - Ensures compatibility with Go 1.25+ OpenRoot security feature
The $ character is commonly used in Java compiled class files for inner classes (e.g., OuterClass$InnerClass.class). Blocking this character prevents extraction of Java-based archives like Apache ActiveMQ. Changes: - Removed $ from blacklistedPathSymbols in files.go - Updated path validation tests to no longer reject $ - Added test cases for Java inner class filenames The $ character is safe in filenames and doesn't cause path traversal or other security issues. Shell variable substitution concerns don't apply to archive extraction paths. Fixes extraction errors like: "path ...WebConsoleStarter$OsgiUtil.class contains illegal characters"
|
🎉 This PR is included in version 1.42.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.