chore: storybook fixes#3066
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughRemoved the "storybook-addon-mock/register" entry from the Storybook addons configuration and updated the "storybook" and "build-storybook" npm scripts to use cross-env for setting NEXT_PRIVATE_LOCAL_WEBPACK and STORYBOOK_DISABLE_TELEMETRY environment variables. ChangesStorybook Config Updates
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
package.json (1)
182-183: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsider adding
STORYBOOK_DISABLE_TELEMETRY=1to thestorybookdev script as well.
STORYBOOK_DISABLE_TELEMETRY=1is only set onbuild-storybookbut not on thestorybookdev script. If the intent is to disable Storybook telemetry, it should be consistent across both scripts to avoid sending telemetry during local development.♻️ Suggested fix
- "storybook": "cross-env NEXT_PRIVATE_LOCAL_WEBPACK=true storybook dev -p 6006", + "storybook": "cross-env NEXT_PRIVATE_LOCAL_WEBPACK=true STORYBOOK_DISABLE_TELEMETRY=1 storybook dev -p 6006",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` around lines 182 - 183, The Storybook scripts are inconsistent because only build-storybook disables telemetry; update the storybook dev script to also include STORYBOOK_DISABLE_TELEMETRY=1 so both commands behave the same. Make the change in the package.json script entries for storybook and build-storybook, keeping NEXT_PRIVATE_LOCAL_WEBPACK=true intact while applying the telemetry flag to the dev command as well.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@package.json`:
- Around line 182-183: The Storybook scripts are inconsistent because only
build-storybook disables telemetry; update the storybook dev script to also
include STORYBOOK_DISABLE_TELEMETRY=1 so both commands behave the same. Make the
change in the package.json script entries for storybook and build-storybook,
keeping NEXT_PRIVATE_LOCAL_WEBPACK=true intact while applying the telemetry flag
to the dev command as well.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 093b012c-3053-4ea4-b90d-dd8c4f912178
📒 Files selected for processing (2)
.storybook/main.tspackage.json
💤 Files with no reviewable changes (1)
- .storybook/main.ts
Summary by CodeRabbit
Bug Fixes
Chores