Skip to content

fix: render extra RBAC rules without extra indentation#591

Merged
adityathebe merged 1 commit into
mainfrom
fix-rbac-extra-indent
May 21, 2026
Merged

fix: render extra RBAC rules without extra indentation#591
adityathebe merged 1 commit into
mainfrom
fix-rbac-extra-indent

Conversation

@adityathebe
Copy link
Copy Markdown
Member

@adityathebe adityathebe commented May 21, 2026

serviceAccount.rbac.extra entries are already expected to render as RBAC rule list items.

The template applied nindent 2, which over-indented the extra rules under rules: and produced invalid or misplaced YAML. Render the provided YAML directly so extra RBAC rules align with the rest of the rule list.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed formatting of custom RBAC rules in Helm chart-generated Kubernetes manifests to ensure correct configuration embedding.

Review Change Stack

serviceAccount.rbac.extra is expected to provide RBAC rule list items aligned under rules.

The template added nindent 2, over-indenting those entries and producing invalid or misplaced YAML. Render the provided YAML directly so extra rules align with the rest of the rule list.
@adityathebe adityathebe enabled auto-merge (rebase) May 21, 2026 12:16
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9dcc17e0-f7fd-4146-a6bd-8fe883dc503a

📥 Commits

Reviewing files that changed from the base of the PR and between af88a22 and addeb1c.

📒 Files selected for processing (1)
  • chart/templates/rbac.yaml

Walkthrough

This PR removes the nindent 2 filter from the Helm template rendering of extra RBAC rules in chart/templates/rbac.yaml. The change adjusts how additional service account RBAC rules are indented when output into the generated Kubernetes manifest.

Changes

RBAC Template Indentation

Layer / File(s) Summary
Extra RBAC rules indentation adjustment
chart/templates/rbac.yaml
Helm template removes nindent 2 filter from .Values.serviceAccount.rbac.extra toYaml rendering, outputting injected RBAC rules at the current indentation level rather than indenting by 2 additional spaces.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: fixing indentation handling when rendering extra RBAC rules in the Helm template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-rbac-extra-indent
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix-rbac-extra-indent

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@adityathebe adityathebe merged commit a2a6ba3 into main May 21, 2026
11 checks passed
@adityathebe adityathebe deleted the fix-rbac-extra-indent branch May 21, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant