-
Notifications
You must be signed in to change notification settings - Fork 5
chore(build): simplify makefile tool paths and regenerate kitchen-sink test data #2958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
5941007
e1e69bf
eb65bfd
ab9a21b
0cc044a
be05923
5dad17a
ceec9e3
6800d87
17c8355
d7ad4b3
fc80676
160e171
300791d
3e1cafa
0b1275d
e1806b6
4a84886
85f5052
e85e510
c6e2baa
92e5bce
4cdf95e
7d0d623
681c32e
b618a65
b3a4a70
54ff450
e403488
4557a9c
7ecce47
d065da7
d1cede8
353b3fa
7e56856
ac38312
94e0ed9
cbf79ae
4ef8c54
77ff874
afdf2b8
d308c87
f1cc0d3
f6cdb9a
6333760
608dffa
5771d74
391db7d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| pre: | ||
| - run: make build |
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -58,8 +58,9 @@ test: | |||||||||
| --succinct --label-filter='!ignore_local' | ||||||||||
|
|
||||||||||
| .PHONY: ci-test | ||||||||||
| ci-test: | ||||||||||
| ginkgo -r -p --skip-package=tests/e2e --keep-going --junit-report junit-report.xml --github-output --output-dir test-reports --succinct | ||||||||||
| ci-test: $(TAILWIND_JS) $(LOCALBIN) | ||||||||||
| go build -o ./.bin/$(NAME) main.go | ||||||||||
| ginkgo -r --skip-package=tests/e2e --keep-going --junit-report junit-report.xml --github-output --output-dir test-reports --succinct | ||||||||||
|
|
||||||||||
| .PHONY: e2e | ||||||||||
| e2e: $(TAILWIND_JS) | ||||||||||
|
|
@@ -149,7 +150,7 @@ build: static | |||||||||
| go build -o ./.bin/$(NAME) -ldflags "-X \"main.version=$(VERSION_TAG) built at $(DATE)\"" main.go | ||||||||||
|
|
||||||||||
| .PHONY: dev | ||||||||||
| dev: | ||||||||||
| dev: static | ||||||||||
| # Disabling CGO because of slow build times in apple silicon (just experimenting) | ||||||||||
| CGO_ENABLED=0 go build -v -o ./.bin/$(NAME) -gcflags="all=-N -l" main.go | ||||||||||
|
|
||||||||||
|
|
@@ -188,22 +189,25 @@ ginkgo: | |||||||||
|
|
||||||||||
| .PHONY: controller-gen | ||||||||||
| controller-gen: install-deps $(LOCALBIN) | ||||||||||
| $(LOCALBIN)/deps install controller-gen@$(CONTROLLER_TOOLS_VERSION) --bin-dir $(LOCALBIN) | ||||||||||
| deps install controller-gen@$(CONTROLLER_TOOLS_VERSION) --bin-dir $(LOCALBIN) | ||||||||||
|
|
||||||||||
| .PHONY: golangci-lint | ||||||||||
| golangci-lint: install-deps $(LOCALBIN) | ||||||||||
| $(LOCALBIN)/deps install golangci/golangci-lint@v$(GOLANGCI_LINT_VERSION) --bin-dir $(LOCALBIN) | ||||||||||
| deps install golangci/golangci-lint@v$(GOLANGCI_LINT_VERSION) --bin-dir $(LOCALBIN) | ||||||||||
|
|
||||||||||
| .PHONY: kustomize | ||||||||||
| kustomize: install-deps $(LOCALBIN) | ||||||||||
| $(LOCALBIN)/deps install kubernetes-sigs/kustomize@$(KUSTOMIZE_VERSION) --bin-dir $(LOCALBIN) | ||||||||||
| deps install kubernetes-sigs/kustomize@$(KUSTOMIZE_VERSION) --bin-dir $(LOCALBIN) | ||||||||||
|
|
||||||||||
| .PHONY: docs\:mcp | ||||||||||
| docs\:mcp: ## Generate MCP tools reference documentation | ||||||||||
| @mkdir -p docs | ||||||||||
| go run ./hack/gen-mcp-docs > docs/mcp-tools.md | ||||||||||
| @echo "Generated docs/mcp-tools.md" | ||||||||||
|
|
||||||||||
| report/kitchen-sink.json: report/build-kitchen-sink.ts report/testdata/kitchen-sink.yaml | ||||||||||
| cd report && ./node_modules/.bin/tsx build-kitchen-sink.ts | ||||||||||
|
Comment on lines
+208
to
+209
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
rg -n 'report/kitchen-sink\.json:|change-types\.schema\.json|schemaPath' Makefile report/build-kitchen-sink.tsRepository: flanksource/mission-control Length of output: 412 Add the schema JSON as an explicit prerequisite for kitchen-sink generation. The Makefile rule at line 214 depends on Proposed fix-report/kitchen-sink.json: report/build-kitchen-sink.ts report/testdata/kitchen-sink.yaml
+report/kitchen-sink.json: report/build-kitchen-sink.ts report/testdata/kitchen-sink.yaml duty/schema/openapi/change-types.schema.json
cd report && ./node_modules/.bin/tsx build-kitchen-sink.ts📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||
|
|
||||||||||
| .PHONY: lint | ||||||||||
| lint: golangci-lint | ||||||||||
| $(GOLANGCI_LINT) run ./... | ||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
$(LOCALBIN)as a prerequisite fordev.devwrites to./.bin/$(NAME)but this target does not create that directory. On a clean checkout,go build -owill fail before the binary is written.Proposed change
📝 Committable suggestion
🤖 Prompt for AI Agents