[feat] 1.76 ensure conversion hooks#783
Merged
Merged
Conversation
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
ipaqsa
added
enhancement
4 tasks
ldmonster
approved these changes
Jun 29, 2026
Fkuloff
pushed a commit
that referenced
this pull request
Jul 7, 2026
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com> (cherry picked from commit 04ede3b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a new
ModuleEnsureHooksconverge task that applies a module'sConversionWebhookresources to the cluster before the main helm release, so the release can adopt them.What this PR does / why we need it
CRD conversion webhooks must exist in the cluster before custom resources are applied. This PR renders a module's templates, extracts the
ConversionWebhookmanifests, and applies them ahead of the helm install.HelmModule.RenderConversionWebhooks— renders the chart, splits the YAML, and returns onlyConversionWebhookmanifests.ModuleManager.EnsureConversionWebhooks— applies those manifests viaKubeObjectPatcher(CreateOrUpdate); no-op for non-helm modules or modules without webhooks.ModuleEnsureHookstask, queued for every enabled module right afterModuleEnsureCRDs(beforeModuleRun).ConversionWebhookExist, computed at module load) so only modules whose templates contain aConversionWebhookare rendered.