[feat] ensure conversion hooks

[Fkuloff]

Overview

Forward-ports the "ensure conversion hooks" feature to main. It shipped to release-1.21 in #783 but is missing on main; this brings main in line. Cherry-pick (-x) of 04ede3b — applied conflict-free on current main (3-way auto-merge), go build ./... and go vet pass.

What this PR does / why we need it

Adds a module-ensure-hooks task that applies a module's ConversionWebhook resources before its Helm release, and wires it into the module converge lifecycle (module_manager, converge-modules, task service, task.go). This lets the cluster's webhook-handler patch the target CRDs' spec.conversion before the module creates custom resources that need converting — otherwise the API server stores those resources before conversion is live and prunes the old-version fields.

Special notes for your reviewer

Straight forward-port of #783; no changes beyond the conflict-free cherry-pick onto main. Original author: Stepan Paksashvili.

[Copilot]

Pull request overview

This PR forward-ports the “ensure conversion hooks” feature to main by introducing a new converge task that applies a module’s ConversionWebhook resources before its Helm release runs, so CRD conversion is in place before custom resources are created.

Changes:

• Adds a new ModuleEnsureHooks task (module-ensure-hooks) and wires it into the task handler service.
• Queues ModuleEnsureHooks during module converge (before ModuleRun) when the module is detected to contain conversion webhook templates.
• Implements webhook detection (static heuristic at module load), rendering (filter rendered manifests by kind: ConversionWebhook), and applying (CreateOrUpdate via KubeObjectPatcher) in the module manager.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/task/tasks/module-ensure-hooks/task.go	New task handler that triggers EnsureConversionWebhooks for a module.
pkg/task/tasks/converge-modules/task.go	Enqueues the new ensure-hooks task in the converge pipeline and adds a helper constructor.
pkg/task/task.go	Adds the new ModuleEnsureHooks task type constant.
pkg/task/service/service.go	Registers the new task handler in the task factory map.
pkg/task/helpers/helpers.go	Updates task-details formatting to include ModuleEnsureHooks.
pkg/module_manager/module_manager.go	Adds EnsureConversionWebhooks and ModuleHasConversionWebhooks to render/apply webhook resources.
pkg/module_manager/models/modules/helm.go	Adds webhook rendering helper that filters rendered YAML docs by ConversionWebhook kind.
pkg/module_manager/models/modules/basic.go	Adds a static “templates contain ConversionWebhook” heuristic computed on module load.
pkg/addon-operator/operator.go	Updates task-details formatting to include ModuleEnsureHooks.
pkg/addon-operator/converge/converge.go	Treats ModuleEnsureHooks as a converge task type.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.