[addon-operator] make module hook registration idempotent#797
Draft
Glitchy-Sheep wants to merge 1 commit into
Draft
[addon-operator] make module hook registration idempotent#797Glitchy-Sheep wants to merge 1 commit into
Glitchy-Sheep wants to merge 1 commit into
Conversation
- AddHook replaces the previously registered hook object in all bindings instead of appending a duplicate: a stale entry keeps a nil HookController and crashes the kube-events dispatcher after a registration retry - registered/controllersReady flags are read and written under the storage lock, giving a happens-before edge between setting hook controllers and observing the readiness flag - RegisterHooks is serialized with a dedicated mutex so two concurrent ModuleRun tasks cannot register the same module twice - getHooks sorts and returns a copy instead of the shared slice Signed-off-by: Roman Berezkin <roman.berezkin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What this PR does / why we need it
Special notes for your reviewer