refactor: remove global factory store initialization and use instance-specific factory store in resource informer

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>

Author: Evsyukov Denis

pkg/kube_events_manager/factory.go

@@ -15,14 +15,7 @@ import (
 	"k8s.io/client-go/tools/cache"
 )
 
-var (
-	DefaultFactoryStore *FactoryStore
-	DefaultSyncTime     = 100 * time.Millisecond
-)
-
-func init() {
-	DefaultFactoryStore = NewFactoryStore()
-}
+var DefaultSyncTime = 100 * time.Millisecond
 
 type FactoryIndex struct {
 	GVR           schema.GroupVersionResource

pkg/kube_events_manager/resource_informer.go

@@ -37,6 +37,7 @@ type resourceInformer struct {
 	GroupVersionResource schema.GroupVersionResource
 	ListOptions          metav1.ListOptions
 
+	defaultFactoryStore *FactoryStore
 	// A cache of objects and filterResults. It is a part of the Monitor's snapshot.
 	cachedObjects map[string]*kemtypes.ObjectAndFilterResult
 	cacheLock     sync.RWMutex
@@ -91,6 +92,7 @@ func newResourceInformer(ns, name string, cfg *resourceInformerConfig) *resource
 		cachedObjectsInfo:      &CachedObjectsInfo{},
 		cachedObjectsIncrement: &CachedObjectsInfo{},
 		logger:                 cfg.logger,
+		defaultFactoryStore:    NewFactoryStore(),
 	}
 	return informer
 }
@@ -455,13 +457,13 @@ func (ei *resourceInformer) start() {
 	go func() {
 		if ei.ctx != nil {
 			<-ei.ctx.Done()
-			DefaultFactoryStore.Stop(ei.id, ei.FactoryIndex)
+			ei.defaultFactoryStore.Stop(ei.id, ei.FactoryIndex)
 		}
 	}()
 
 	// TODO: separate handler and informer
 	errorHandler := newWatchErrorHandler(ei.Monitor.Metadata.DebugName, ei.Monitor.Kind, ei.Monitor.Metadata.LogLabels, ei.metricStorage, ei.logger.Named("watch-error-handler"))
-	err := DefaultFactoryStore.Start(ei.ctx, ei.id, ei.KubeClient.Dynamic(), ei.FactoryIndex, ei, errorHandler)
+	err := ei.defaultFactoryStore.Start(ei.ctx, ei.id, ei.KubeClient.Dynamic(), ei.FactoryIndex, ei, errorHandler)
 	if err != nil {
 		ei.Monitor.Logger.Error("cache is not synced for informer", slog.String("debugName", ei.Monitor.Metadata.DebugName))
 		return

test/hook/context/generator.go

@@ -67,8 +67,6 @@ func NewBindingContextController(config string, logger *log.Logger, version ...f
 
 	b.KubeEventsManager = kubeeventsmanager.NewKubeEventsManager(ctx, b.fakeCluster.Client, b.logger.Named("kube-events-manager"))
 	b.KubeEventsManager.WithMetricStorage(metricstorage.NewMetricStorage(ctx, "metrics-prefix", false, log.NewNop()))
-	// Re-create factory to drop informers created using different b.fakeCluster.Client.
-	// kubeeventsmanager.DefaultFactoryStore = kubeeventsmanager.NewFactoryStore()
 
 	b.ScheduleManager = schedulemanager.NewScheduleManager(ctx, b.logger.Named("schedule-manager"))