SEO meta description doesn't take from site settings

[roshanjonah]

Current Behavior

If you type the description in the Basics -> Forum description field, the description. It uses it for meta description SEO only if the "Homepage" is set to show "All discussions". If you set it to "Tags", a weird "All tags" is used as meta description and not the forum description you've put in.

Steps to Reproduce

1. Go to site administration
2. Go to Basics
3. Set the forum description and set "Homepage" to "Tags"
4. Then go and visit the forum and look at the source code
5. Search for meta description

Expected Behavior

It is supposed to use Forum description provided like it correctly does when it is set to "All discussions" as homepage.

Screenshots

Environment

• Flarum version: 1.8.5
• Website URL: https://hub.spotzee.com
• Webserver: nginx
• Hosting environment: dedicated
• PHP version: 8.3.4
• Browser: Brave v1.64.109

Output of php flarum info

Flarum core: 1.8.5
PHP version: 8.3.4
MySQL version: 8.0.13
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, json, pcntl, random, Reflection, SPL, session, standard, sodium, mysqlnd, PDO, xml, bcmath, calendar, ctype, curl, dom, mbstring, FFI, fileinfo, ftp, gd, gettext, gmp, iconv, igbinary, imagick, imap, intl, exif, msgpack, mysqli, pdo_mysql, pdo_pgsql, pdo_sqlite, pgsql, Phar, posix, readline, redis, shmop, SimpleXML, soap, sockets, sqlite3, sysvmsg, sysvsem, sysvshm, tokenizer, xmlreader, xmlwriter, xsl, zip, memcached, Zend OPcache
+--------------------------+---------+--------+
| Flarum Extensions        |         |        |
+--------------------------+---------+--------+
| ID                       | Version | Commit |
+--------------------------+---------+--------+
| flarum-flags             | v1.8.0  |        |
| flarum-tags              | v1.8.0  |        |
| flarum-approval          | v1.8.1  |        |
| flarum-suspend           | v1.8.1  |        |
| v17development-seo       | v1.8.1  |        |
| fof-sitemap              | 2.2.1   |        |
| fof-share-social         | 1.2.0   |        |
| fof-reactions            | 1.4.1   |        |
| fof-oauth                | 1.6.8   |        |
| fof-gamification         | 1.6.7   |        |
| fof-formatting           | 1.0.3   |        |
| fof-disposable-emails    | 1.0.0   |        |
| fof-best-answer          | 1.4.2   |        |
| fof-anti-spam            | 1.1.2   |        |
| flarum-subscriptions     | v1.8.0  |        |
| flarum-sticky            | v1.8.0  |        |
| flarum-statistics        | v1.8.0  |        |
| flarum-nicknames         | v1.8.0  |        |
| flarum-mentions          | v1.8.3  |        |
| flarum-markdown          | v1.8.0  |        |
| flarum-lock              | v1.8.0  |        |
| flarum-likes             | v1.8.0  |        |
| flarum-lang-english      | v1.8.0  |        |
| flarum-extension-manager | v1.0.3  |        |
| flarum-emoji             | v1.8.0  |        |
| flarum-bbcode            | v1.8.0  |        |
+--------------------------+---------+--------+
Base URL: https://hub.spotzee.com
Installation path: /home/xxx/hub.spotzee.com
Queue driver: sync
Session driver: file
Scheduler status: Active
Mail driver: smtp
Debug mode: off

Possible Solution

Use the forum description like it is currently doing for the "All discussions" homepage mode for the "Tags" homepage mode as well.

Additional Context

No response

[imorland]

I'm so sorry it's taken us so long to look at this, especially considering the simplicity of the fix.

I'll include this in both 1.8.16 and 2.0.0-rc.1, thank you for your patience