Makefile: auto-detect Python/pip, add venv + help; ignore generated presentation HTML#637
Open
John15321 wants to merge 1 commit into
Open
Makefile: auto-detect Python/pip, add venv + help; ignore generated presentation HTML#637John15321 wants to merge 1 commit into
John15321 wants to merge 1 commit into
Conversation
…resentation HTML - Detect PYTHON (python3/python) and PIP (uv/pip) automatically; overridable - Add requirements.txt; getdeps installs from it - Add venv and help targets - Ignore .venv/, __pycache__/, *.pyc - Treat static/presentations/*/index.html as build artifacts; regenerate in build-preview - Document the new workflow in README Signed-off-by: Jan Bronicki <janbronicki@gmail.com>
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-wave-085522403-637.westeurope.1.azurestaticapps.net |
There was a problem hiding this comment.
Pull request overview
This PR improves the local/CI developer workflow for building the Flatcar website by making Python tooling setup more automatic (and overridable), adding a simple dependency manifest + venv target, and treating generated presentation HTML as build artifacts rather than tracked sources.
Changes:
- Update
Makefileto auto-detectPYTHON/PIP, addhelpandvenvtargets, and makebuild-previewregenerate presentations. - Add
requirements.txtand updategetdepsto install from it. - Remove tracked generated presentation HTML and ignore regenerated outputs (plus common Python artifacts) via
.gitignore; document the new workflow inREADME.md.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| static/presentations/keycloak-scope-token/index.html | Remove generated Marp output from version control (now treated as build artifact). |
| static/presentations/keycloak-assign-roles/index.html | Remove generated Marp output from version control (now treated as build artifact). |
| static/presentations/auth0-setup/index.html | Remove generated Marp output from version control (now treated as build artifact). |
| requirements.txt | Introduce a canonical Python dependency list for Makefile-driven installs. |
| README.md | Document Python tool detection/overrides and the venv-based workflow. |
| Makefile | Add Python/pip auto-detection, help/venv, and ensure CI preview builds presentations. |
| .gitignore | Ignore .venv/, Python bytecode/cache, and generated static/presentations/*/index.html. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+81
to
82
| build-preview: getdeps docs presentations ## Build a preview site (used by CI) | ||
| hugo --theme=flatcar -F -b ${DEPLOY_PRIME_URL} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jan Bronicki janbronicki@gmail.com