Migrate from AppImage extra-data to deb package extraction#103
Open
besdar wants to merge 5 commits into
Open
Conversation
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
✅ Test build succeeded. To test this build, install it from the testing repository: Built for aarch64 and x86_64 architectures. |
Contributor
|
@besdar Thanks for raising this PR. We'll review this PR |
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
✅ Test build succeeded. To test this build, install it from the testing repository: Built for aarch64 and x86_64 architectures. |
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
✅ Test build succeeded. To test this build, install it from the testing repository: Built for aarch64 and x86_64 architectures. Warnings can be promoted to errors in the future. Please try to resolve them.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @helloanoop and @Pragadesh-45
This PR migrates the Bruno Flatpak from using
extra-datasource type with AppImage extraction to a standard deb package extraction approach.Files Changed
com.usebruno.Bruno.ymlx-checker-data(Enables automatic version updates via Flathub's update bot)com.usebruno.Bruno.metainfo.xmlflathub.jsoncom.usebruno.Bruno.desktopcom.usebruno.Bruno.pngapply_extra.shWhy removing
apply_extra.shis necessaryThe key change in this PR is removing
apply_extra.shand theextra-datasource type. This helps Bruno to be labeled as "Community Built" on Flathub.How
extra-data+apply_extra.shworks (the old way)With
extra-data:apply_extra.shextracts the AppImageProblem: Flathub's team can consider this as "proprietary" because the build servers never touch the actual application files. The app binary bypasses the entire build process. That's why
extra-datais primarily used for closed-source apps.How
type: fileworks (the new way)With
type: file:apply_extra.shneededResult: Flathub's team easier considers this as "Community Built" because the build servers process the source files.
Why not build Electron apps from source (to prove it is community built)?
Building Electron apps from source in Flatpak environments is complex and uncommon because:
See also: Flatpak documentation on building Electron apps
Using pre-built packages (
.deb,.tar.gz,.AppImage) and extracting them during the build phase is the standard practice for Electron apps on Flathub:.debpackages.AppImage.tar.gzarchivesAlthough building from source is possible, if you want to build Bruno from source, I can make this change.
Why
.debinstead of.AppImageBoth formats contain the same application files, but
.debhas several advantages:.deb.AppImagebsdtarone-linerunappimagemodule/opt,/usr/shareunappimagefirstCode comparison: old vs new extraction
The previous manifest needed an entire module just to build
unappimage:With
.deb, extraction is a single line:Testing