Skip to content

Commit 341fa77

Browse files
committed
node: Add tests for packages missing the 'resolved' field
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
1 parent 9da3738 commit 341fa77

3 files changed

Lines changed: 62 additions & 0 deletions

File tree

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
{
2+
"name": "@flatpak-node-generator-tests/missing-resolved-npm",
3+
"version": "1.0.0",
4+
"lockfileVersion": 2,
5+
"requires": true,
6+
"packages": {
7+
"": {
8+
"name": "@flatpak-node-generator-tests/missing-resolved-npm",
9+
"version": "1.0.0",
10+
"dependencies": {
11+
"word-wrap": "^1.2.3"
12+
}
13+
},
14+
"node_modules/word-wrap": {
15+
"version": "1.2.3",
16+
"integrity": "sha512-Hz/mrNwitNRh/HUAtM/VT/5VH+ygD6DV7mYKZAtHOrbs8U7lvPS6xf7EJKMF0uW1KJCl0H701g3ZGus+muE5vQ==",
17+
"engines": {
18+
"node": ">=0.10.0"
19+
}
20+
}
21+
},
22+
"dependencies": {
23+
"word-wrap": {
24+
"version": "1.2.3",
25+
"integrity": "sha512-Hz/mrNwitNRh/HUAtM/VT/5VH+ygD6DV7mYKZAtHOrbs8U7lvPS6xf7EJKMF0uW1KJCl0H701g3ZGus+muE5vQ=="
26+
}
27+
}
28+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"name": "@flatpak-node-generator-tests/missing-resolved-npm",
3+
"version": "1.0.0",
4+
"dependencies": {
5+
"word-wrap": "^1.2.3"
6+
}
7+
}

node/tests/test_providers.py

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,33 @@ async def test_local_link(
9090
assert hello_txt.read_text() == 'Hello!'
9191

9292

93+
async def test_missing_resolved_field(
94+
flatpak_builder: FlatpakBuilder,
95+
npm_provider_factory_spec: ProviderFactorySpec,
96+
) -> None:
97+
# Only test on lockfile v2.
98+
node_version = 16
99+
100+
with ManifestGenerator() as gen:
101+
await npm_provider_factory_spec.generate_modules(
102+
'missing-resolved-npm', gen, node_version
103+
)
104+
105+
flatpak_builder.build(
106+
sources=gen.ordered_sources(),
107+
commands=[
108+
npm_provider_factory_spec.install_command,
109+
f"""node -e 'require("word-wrap")'""",
110+
],
111+
use_node=node_version,
112+
)
113+
114+
word_wrap_package_json = (
115+
flatpak_builder.module_dir / 'node_modules' / 'word-wrap' / 'package.json'
116+
)
117+
assert word_wrap_package_json.exists()
118+
119+
93120
async def test_special_electron(
94121
flatpak_builder: FlatpakBuilder,
95122
provider_factory_spec: ProviderFactorySpec,

0 commit comments

Comments
 (0)