Skip to content

pip: use universal wheels only if there are no others #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
allisonkarlitskaya wants to merge 1 commit into from
+6 −1
Closed

pip: use universal wheels only if there are no others #525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pip/flatpak-pip-generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,12 @@ def collect(compat_fn) -> list[dict]:
(f for f in get_pypi_files() if is_universal(f["filename"])),
None,
)
if pypi_universal:

# Only take a universal wheel if there are no platform-specific ones: the
# platform-specific ones likely contain precompiled fast-paths. In that
# case we'll either want the platform-specific wheels or a source build,
# depending on user preference.
if pypi_universal and not any(is_platform_wheel(f["filename"]) for f in get_pypi_files()):
return [make_source(pypi_universal)], []

if not is_preferred:
Expand Down
Loading