Skip to content

Support Flutter 3.44 text input changes#583

Merged
Amir-P merged 4 commits into
fleather-editor:masterfrom
john-unger:fleather-flutter-344-text-input-l10n
May 25, 2026
Merged

Support Flutter 3.44 text input changes#583
Amir-P merged 4 commits into
fleather-editor:masterfrom
john-unger:fleather-flutter-344-text-input-l10n

Conversation

@john-unger
Copy link
Copy Markdown
Contributor

@john-unger john-unger commented May 21, 2026

Adds compatibility for Flutter 3.44 text input API changes, updates deprecated text input style handling, and fixes the pt_BR ARB filename so localization generation succeeds.

Copy link
Copy Markdown
Member

@Amir-P Amir-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @john-unger, thanks for contributing! I think you also need to update the .github/workflows/fleather.yml to use the latest Flutter version for running the workflow. Other than, it looks good to me.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.11%. Comparing base (ebd507e) to head (cd0eb02).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
+ Coverage   85.72%   88.11%   +2.39%     
==========================================
  Files          50       63      +13     
  Lines        8096    10899    +2803     
==========================================
+ Hits         6940     9604    +2664     
- Misses       1156     1295     +139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@john-unger
Copy link
Copy Markdown
Contributor Author

thank you @Amir-P i have made that update, and fixed the locale issue on the GHA with pt-BR. Can you take it from here?

Copy link
Copy Markdown
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a small comment, can you please check?

@@ -200,6 +200,9 @@ mixin RawEditorStateTextInputClientMixin on EditorState
// no-op
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter's EditableTextState implements this method with

@override
bool onFocusReceived() {
  if (mounted && !_hasFocus && widget.focusNode.canRequestFocus) {
    widget.focusNode.requestFocus();
    return true;
  }
  return false;
}

Should we implement something similar?

@Amir-P Amir-P requested a review from amantoux May 25, 2026 13:27
Copy link
Copy Markdown
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Amir-P Amir-P merged commit e98e277 into fleather-editor:master May 25, 2026
3 checks passed
@john-unger john-unger deleted the fleather-flutter-344-text-input-l10n branch May 26, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants