Support Flutter 3.44 text input changes#583
Conversation
Amir-P
left a comment
There was a problem hiding this comment.
Hi @john-unger, thanks for contributing! I think you also need to update the .github/workflows/fleather.yml to use the latest Flutter version for running the workflow. Other than, it looks good to me.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #583 +/- ##
==========================================
+ Coverage 85.72% 88.11% +2.39%
==========================================
Files 50 63 +13
Lines 8096 10899 +2803
==========================================
+ Hits 6940 9604 +2664
- Misses 1156 1295 +139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
thank you @Amir-P i have made that update, and fixed the locale issue on the GHA with pt-BR. Can you take it from here? |
amantoux
left a comment
There was a problem hiding this comment.
I have a small comment, can you please check?
| @@ -200,6 +200,9 @@ mixin RawEditorStateTextInputClientMixin on EditorState | |||
| // no-op | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Flutter's EditableTextState implements this method with
@override
bool onFocusReceived() {
if (mounted && !_hasFocus && widget.focusNode.canRequestFocus) {
widget.focusNode.requestFocus();
return true;
}
return false;
}Should we implement something similar?
Adds compatibility for Flutter 3.44 text input API changes, updates deprecated text input style handling, and fixes the pt_BR ARB filename so localization generation succeeds.