Merge pull request #122 from fleetbase/fix/smart-nav-menu-shortcut-permission

fix(smart-nav-menu): use parent extension id for shortcut permission check

Author: roncodes

addon/components/layout/header/smart-nav-menu.js

@@ -161,8 +161,14 @@ export default class LayoutHeaderSmartNavMenuComponent extends Component {
         const raw = this.universe.headerMenuItems ?? [];
         const visible = [];
         for (const item of raw) {
+            // Shortcuts are not standalone extensions — they should be visible
+            // if and only if their parent extension is visible.  Use _parentId
+            // for the ability check so the shortcut inherits the parent's
+            // permission rather than being checked against its own (non-existent)
+            // extension ability, which would always throw and default to visible.
+            const abilityId = item._isShortcut && item._parentId ? item._parentId : item.id;
             try {
-                if (this.abilities.can(`${item.id} see extension`)) {
+                if (this.abilities.can(`${abilityId} see extension`)) {
                     visible.push(item);
                 }
             } catch (_) {

package.json

@@ -1,6 +1,6 @@
 {
     "name": "@fleetbase/ember-ui",
-    "version": "0.3.24",
+    "version": "0.3.25",
     "description": "Fleetbase UI provides all the interface components, helpers, services and utilities for building a Fleetbase extension into the Console.",
     "keywords": [
         "fleetbase-ui",