Skip to content

Fix DateTimeInput controlled editing#142

Merged
roncodes merged 1 commit into
mainfrom
dev-v0.3.41
Jul 2, 2026
Merged

Fix DateTimeInput controlled editing#142
roncodes merged 1 commit into
mainfrom
dev-v0.3.41

Conversation

@roncodes

@roncodes roncodes commented Jul 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Fixes DateTimeInput editing regression by removing the live @value resync that caused Fleet-Ops order schedule inputs to reset while typing/selecting.
  • Keeps ISO datetime string hydration support for initial values.
  • Stops emitting null callbacks for incomplete native date/time input states.
  • Bumps @fleetbase/ember-ui to 0.3.41.

Root cause

DateTimeInput was changed to resync internal native input state whenever @value changed. Fleet-Ops order forms immediately write the DateTimeInput callback value back into @value, so the component interrupted its own date/time edit cycle and could clear/reset the schedule input.

Validation

  • CI=true pnpm --dir packages/ember-ui exec ember test --filter='Integration | Component | date-time-input'
  • CI=true pnpm --dir packages/ember-ui exec eslint addon/components/date-time-input.js tests/integration/components/date-time-input-test.js
  • CI=true pnpm --dir packages/ember-ui exec ember-template-lint addon/components/date-time-input.hbs
  • git diff --cached --check

@roncodes roncodes marked this pull request as ready for review July 2, 2026 05:56
@roncodes roncodes merged commit 77210bb into main Jul 2, 2026
7 checks passed
@roncodes roncodes deleted the dev-v0.3.41 branch July 2, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant